Skip to content

fix(Bun.write) add support to new Response(readable) #15631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

fix(Bun.write) add support to new Response(readable) #15631

wants to merge 17 commits into from

Conversation

cirospaciari
Copy link
Member

What does this PR do?

Fix: #13237

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Test

@robobun
Copy link

robobun commented Dec 7, 2024 •
edited
Loading

Updated 3:13 PM PT - Dec 17th, 2024

❌ @cirospaciari, your commit dc85530 has 5 failures in #8118:

🧪   try this PR locally:

bunx bun-pr 15631

Jarred-Sumner
Jarred-Sumner previously approved these changes Dec 7, 2024
View reviewed changes
@cirospaciari cirospaciari mentioned this pull request Dec 16, 2024
Closed
@Jarred-Sumner
Copy link
Collaborator

I think some of these test failures are real

@cirospaciari
Copy link
Member Author

I think some of these test failures are real

Yeah me too, let me go back to this after S3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Jarred-Sumner left review comments

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bun.write with new Response(req.body) hangs
3 participants
@cirospaciari @robobun @Jarred-Sumner