Skip to content

Commit 7eb2bdf

Browse files
author
Taylor Payne
authored
fix: Ensure LMS_ROOT_URL is defined in i18n and assets settings modules (#1256)
When running the management commands related to translations and static assets in `tutor/templates/build/openedx/Dockerfile`, LMS_ROOT_URL needs to have a valid value, otherwise the build will fail. Tutor has relied on there being a valid value for LMS_ROOT_URL present in `lms/envs/common.py` and `cms/envs/common.py`, but upcoming changes to edx-platform (#37045) will create the need to ensure LMS_ROOT_URL has a valid value.
1 parent 35fe2dd commit 7eb2bdf

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

tutor/templates/build/openedx/settings/partials/assets.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,8 @@
1414
DATABASES = {
1515
"default": {},
1616
}
17+
# Dummy value required for the static asset build steps to run,
18+
# but it has no impact on the output produced by those steps.
19+
LMS_ROOT_URL = "https://lms.local"
1720

1821
{{ patch("openedx-common-assets-settings") }}

tutor/templates/build/openedx/settings/partials/i18n.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
DATABASES = {
1010
"default": {},
1111
}
12+
# Dummy value required for the i18n build steps to run, but
13+
# it has no impact on the output produced by those steps.
14+
LMS_ROOT_URL = "https://lms.local"
1215

1316
derive_settings(__name__)
1417

0 commit comments

Comments
 (0)