-
Notifications
You must be signed in to change notification settings - Fork 505
i18n.py applies patch after derive_settings method #1292
Copy link
Copy link
Open
Description
The template at tutor/templates/build/openedx/settings/partials/i18n.py#L16 applies {{ patch("openedx-common-i18n-settings") }} after derive_settings(name). This causes derived values in Studio (e.g., FRONTEND_REGISTER_URL = LMS_ROOT_URL + "/register") to be evaluated before LMS_ROOT_URL can be set by the patch. During image build, the CMS translations step fails:
RUN ./manage.py cms --settings=tutor.i18n compile_xblock_translations
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
# in cms/envs/common.py when LMS_ROOT_URL is None
There’s already a fix in the release branch: #1256, but I suggest reordering the patch in tagged versions too, since the impact goes beyond image builds to other workflows that rely on derived settings.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Pending Triage