Skip to content

Commit b5279f4

Browse files
DavidS-ovmactions-user
authored andcommitted
Remove auto-tagging timeline entry (ENG-2436) (#4512)
<img width="2174" height="1962" alt="image" src="https://github.com/user-attachments/assets/5b01dc7a-95fd-43e6-99f2-94630d54abd3" /> <!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Summary This PR removes the auto-tagging timeline entry from the change analysis workflow, as all customers have now migrated to CLI version 1.16.4 or later. ## Changes ### Core Changes - **Removed `ChangeTimelineEntryV2IDAutoTagging` from `PopulateChangeTimelineV2`** in `services/api-server/service/changeanalysis/changetimeline.go` - Timeline entries no longer include auto-tagging step - **Removed auto-tagging from `GetChangeTimelineV2`** function - Removed call to `GetAutoTaggingTimelineEntry` - Removed the function `GetAutoTaggingTimelineEntry` entirely - **Removed `TrackChangeTimelineV2Entry` call for auto-tagging** in `services/api-server/service/changeanalysis/change_analysis.go` - Auto-tagging logic now runs without timeline tracking - Added comment noting the timeline entry was removed per ENG-2436 - **Removed auto-tagging label from `resetChangeAnalysisTables`** in `services/api-server/service/changeanalysis/shared.go` - Timeline reset no longer includes auto-tagging entry - **Removed `ChangeTimelineEntryV2IDAutoTagging` constant** from `go/sdp-go/changetimeline.go` - Removed from `allChangeTimelineEntryV2IDs` slice - Kept deprecated fields in change_analysis.go for backward compatibility with old changes ### Test Updates - Updated `TestChangeTimelineV2` to remove auto-tagging test assertions - Updated `TestCreateInstantChangeTimelineEntry` to use change validation instead of auto-tagging - Updated `TestGetChangeTimelineEntryFromDatabase` expected count from 8 to 7 entries - Updated `TestPopulateChangeTimelineV2FeatureFlags` expected count from 9 to 8 entries - Updated `TestGetChangeTimelineV2` expected count from 8 to 7 entries - Removed auto-tagging test case from `go/sdp-go/changetimeline_test.go` ## Testing - ✅ All modified Go packages compile successfully - ✅ Code builds without errors - Tests require database connection (not available in CI-less environment) ## Migration Notes This is a cleanup task following the successful migration of all customers to CLI version 1.16.4+. The auto-tagging functionality itself is preserved; only the timeline entry tracking has been removed. ## Checklist - [x] Removed auto-tagging from PopulateChangeTimelineV2 - [x] Removed auto-tagging from GetChangeTimelineV2 - [x] Removed GetAutoTaggingTimelineEntry function - [x] Removed TrackChangeTimelineV2Entry call in change_analysis.go - [x] Removed auto-tagging from resetChangeAnalysisTables - [x] Removed timeline entry ID constant from SDP - [x] Updated all affected tests - [x] Code compiles successfully <!-- CURSOR_AGENT_PR_BODY_END --> Linear Issue: [ENG-2436](https://linear.app/overmind/issue/ENG-2436/remove-auto-tagging-time-line-entry-now-we-are-fully-adopted) <div><a href="https://cursor.com/agents/bc-7c3f5ddd-33ec-48f9-ae4f-04ecb9a8ce16"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/background-agent?bcId=bc-7c3f5ddd-33ec-48f9-ae4f-04ecb9a8ce16"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div> GitOrigin-RevId: ff9c45adb59683fd3523af1c93b663ff3e42b00a
1 parent a298f8f commit b5279f4

2 files changed

Lines changed: 0 additions & 11 deletions

File tree

go/sdp-go/changetimeline.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,6 @@ var (
6767
Label: "calculated_labels",
6868
Name: "Apply auto labels",
6969
}
70-
// Tracks the application of auto tags for a change
71-
ChangeTimelineEntryV2IDAutoTagging = ChangeTimelineEntryV2ID{
72-
Label: "auto_tagging",
73-
Name: "Auto Tagging",
74-
}
7570
// Tracks the validation of a change. This happens after the change is
7671
// complete and at time of writing is not generally available
7772
ChangeTimelineEntryV2IDChangeValidation = ChangeTimelineEntryV2ID{
@@ -124,7 +119,6 @@ var allChangeTimelineEntryV2IDs = []ChangeTimelineEntryV2ID{
124119
ChangeTimelineEntryV2IDAnalyzedSignals,
125120
ChangeTimelineEntryV2IDCalculatedRisks,
126121
ChangeTimelineEntryV2IDCalculatedLabels,
127-
ChangeTimelineEntryV2IDAutoTagging,
128122
ChangeTimelineEntryV2IDChangeValidation,
129123
ChangeTimelineEntryV2IDRecordObservations,
130124
ChangeTimelineEntryV2IDFormHypotheses,

go/sdp-go/changetimeline_test.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ func TestChangeTimelineEntryNameConversion(t *testing.T) {
5252
entryID: ChangeTimelineEntryV2IDCalculatedRisks,
5353
hasInProgressVariant: false,
5454
},
55-
{
56-
name: "Auto Tagging (no in-progress variant)",
57-
entryID: ChangeTimelineEntryV2IDAutoTagging,
58-
hasInProgressVariant: false,
59-
},
6055
{
6156
name: "Change Validation (no in-progress variant)",
6257
entryID: ChangeTimelineEntryV2IDChangeValidation,

0 commit comments

Comments
 (0)