feat: create Elastic SAN volume snapshot adapter (#4209)

<img width="2934" height="1992" alt="image"
src="https://github.com/user-attachments/assets/b29c553f-4169-478a-8f1a-04f4b5caf8b1"
/>

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Introduces a new Azure resource adapter and changes GET query parsing
for Azure to accept full resource IDs, which could affect query behavior
for Azure adapters if path-key mappings are missing or incorrect.
>
> **Overview**
> Adds a new Azure adapter for Elastic SAN volume snapshots, including
an Azure SDK client wrapper, lookups/linking to parent Elastic
SAN/volume group (and source volume when available), Terraform mappings,
and unit tests/mocks.
>
> Extends the core `standardAdapterCore.Get` path parsing to accept full
Azure resource IDs (e.g. from Terraform mappings) by extracting query
parts based on per-type path key definitions, returning explicit query
errors when unsupported.
>
> Also updates dependencies (`armelasticsan`), registers the new adapter
in `azure/manual/adapters.go`, adds ElasticSAN item types/resources +
resourceID path-key mapping, tightens k8s `Endpoints` staticcheck
suppressions, and makes multiple tests safer by returning after
`t.Fatal`/`t.Fatalf` to avoid nil dereferences.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c7e10ad43d6ec2031feae80015364980a25527af. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

GitOrigin-RevId: 97899d2e8b23eae053e5a6612affd3df5d872e73

Author: Lionel-Wilson

aws-source/adapters/ecs-task_test.go

@@ -124,6 +124,7 @@ func TestTaskGetInputMapper(t *testing.T) {
 
 		if input == nil {
 			t.Fatal("input is nil")
+			return
 		}
 
 		if *input.Cluster != "test-ECSCluster-Bt4SqcM3CURk" {

cmd/auth_client_test.go

@@ -208,6 +208,7 @@ func TestNewRetryableHTTPClientRespectsProxy(t *testing.T) {
 
 	if httpTransport == nil {
 		t.Fatal("Could not get http.Transport")
+		return
 	}
 
 	// Verify proxy function is set to ProxyFromEnvironment

cmd/explore_test.go

@@ -60,6 +60,7 @@ func TestUnifiedGCPConfigs(t *testing.T) {
 
 			if foundConfig == nil {
 				t.Fatalf("Could not find config for project %s in result", originalConfig.ProjectID)
+				return
 			}
 
 			if !reflect.DeepEqual(foundConfig.Regions, originalConfig.Regions) {
@@ -115,9 +116,11 @@ func TestUnifiedGCPConfigs(t *testing.T) {
 
 		if unifiedConfig == nil {
 			t.Fatal("Could not find unified-project config in result")
+			return
 		}
 		if differentConfig == nil {
 			t.Fatal("Could not find different-project config in result")
+			return
 		}
 
 		// Verify unified config has all regions
@@ -315,9 +318,11 @@ func TestUnifiedAzureConfigs(t *testing.T) {
 
 		if unifiedConfig == nil {
 			t.Fatal("Could not find config for subscription 00000000-0000-0000-0000-000000000001 in result")
+			return
 		}
 		if differentConfig == nil {
 			t.Fatal("Could not find config for subscription 00000000-0000-0000-0000-000000000002 in result")
+			return
 		}
 
 		// Verify the first config was kept (tenant-first, client-first)

go.mod

@@ -50,6 +50,7 @@ require (
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v7 v7.3.0
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/cosmos/armcosmos/v3 v3.4.0
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/dns/armdns v1.2.0
+	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/elasticsan/armelasticsan v1.2.0
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/keyvault/armkeyvault/v2 v2.0.1
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/msi/armmsi v1.3.0
 	github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v9 v9.0.0

go.sum

@@ -124,6 +124,8 @@ github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/cosmos/armcosmos/v3 v3.4.0
 github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/cosmos/armcosmos/v3 v3.4.0/go.mod h1:Bb7kqorvA2acMCNFac+2ldoQWi7QrcMdH+9Gg9C7fSM=
 github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/dns/armdns v1.2.0 h1:lpOxwrQ919lCZoNCd69rVt8u1eLZuMORrGXqy8sNf3c=
 github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/dns/armdns v1.2.0/go.mod h1:fSvRkb8d26z9dbL40Uf/OO6Vo9iExtZK3D0ulRV+8M0=
+github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/elasticsan/armelasticsan v1.2.0 h1:8xYBtaMs3Msy1bFYTVrVFBh05JUGNMMP/v3z3x5hoIw=
+github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/elasticsan/armelasticsan v1.2.0/go.mod h1:bXxc3uCnIUCh68pl4njcH45qUgRuR0kZfR6v06k18/A=
 github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/v3 v3.1.1 h1:1kpY4qe+BGAH2ykv4baVSqyx+AY5VjXeJ15SldlU6hs=
 github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/v3 v3.1.1/go.mod h1:nT6cWpWdUt+g81yuKmjeYPUtI73Ak3yQIT4PVVsCEEQ=
 github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/keyvault/armkeyvault/v2 v2.0.1 h1:nFZ7AvJqTpWobmnZlprsK6GucrByFsXWB+DwkhRxM9I=

go/discovery/adapter_test.go

@@ -708,6 +708,7 @@ func TestNewQueryResultStream(t *testing.T) {
 	// Test Initialization
 	if stream == nil {
 		t.Fatal("Expected stream to be initialized, got nil")
+		return
 	}
 	if stream.itemHandler == nil || stream.errHandler == nil {
 		t.Fatal("Expected handlers to be set")

k8s-source/adapters/endpoints.go

@@ -7,7 +7,6 @@
 // and acceptable. When the SDK eventually drops support for v1.Endpoints we
 // will need to split out version-specific builds of the k8s-source.
 
-//nolint:staticcheck // See note at top of file
 package adapters
 
 import (
@@ -18,7 +17,7 @@ import (
 	"k8s.io/client-go/kubernetes"
 )
 
-func EndpointsExtractor(resource *v1.Endpoints, scope string) ([]*sdp.LinkedItemQuery, error) {
+func EndpointsExtractor(resource *v1.Endpoints, scope string) ([]*sdp.LinkedItemQuery, error) { //nolint:staticcheck,nolintlint // SA1019: v1.Endpoints deprecated; see note at top of file
 	queries := make([]*sdp.LinkedItemQuery, 0)
 
 	sd, err := ParseScope(scope, true)
@@ -72,15 +71,15 @@ func EndpointsExtractor(resource *v1.Endpoints, scope string) ([]*sdp.LinkedItem
 }
 
 func newEndpointsAdapter(cs *kubernetes.Clientset, cluster string, namespaces []string, cache sdpcache.Cache) discovery.ListableAdapter {
-	return &KubeTypeAdapter[*v1.Endpoints, *v1.EndpointsList]{
+	return &KubeTypeAdapter[*v1.Endpoints, *v1.EndpointsList]{ //nolint:staticcheck,nolintlint // SA1019: v1.Endpoints deprecated; see note at top of file
 		ClusterName: cluster,
 		Namespaces:  namespaces,
 		TypeName:    "Endpoints",
-		NamespacedInterfaceBuilder: func(namespace string) ItemInterface[*v1.Endpoints, *v1.EndpointsList] {
+		NamespacedInterfaceBuilder: func(namespace string) ItemInterface[*v1.Endpoints, *v1.EndpointsList] { //nolint:staticcheck,nolintlint // SA1019
 			return cs.CoreV1().Endpoints(namespace)
 		},
-		ListExtractor: func(list *v1.EndpointsList) ([]*v1.Endpoints, error) {
-			extracted := make([]*v1.Endpoints, len(list.Items))
+		ListExtractor: func(list *v1.EndpointsList) ([]*v1.Endpoints, error) { //nolint:staticcheck,nolintlint // SA1019
+			extracted := make([]*v1.Endpoints, len(list.Items)) //nolint:staticcheck,nolintlint // SA1019
 
 			for i := range list.Items {
 				extracted[i] = &list.Items[i]

sources/azure/clients/elastic-san-volume-snapshot-client.go

@@ -0,0 +1,35 @@
+package clients
+
+import (
+	"context"
+
+	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/elasticsan/armelasticsan"
+)
+
+//go:generate mockgen -destination=../shared/mocks/mock_elastic_san_volume_snapshot_client.go -package=mocks -source=elastic-san-volume-snapshot-client.go
+
+// ElasticSanVolumeSnapshotPager is a type alias for the generic Pager interface with volume snapshot list response type.
+type ElasticSanVolumeSnapshotPager = Pager[armelasticsan.VolumeSnapshotsClientListByVolumeGroupResponse]
+
+// ElasticSanVolumeSnapshotClient is an interface for interacting with Azure Elastic SAN volume snapshots.
+type ElasticSanVolumeSnapshotClient interface {
+	Get(ctx context.Context, resourceGroupName string, elasticSanName string, volumeGroupName string, snapshotName string, options *armelasticsan.VolumeSnapshotsClientGetOptions) (armelasticsan.VolumeSnapshotsClientGetResponse, error)
+	ListByVolumeGroup(ctx context.Context, resourceGroupName string, elasticSanName string, volumeGroupName string, options *armelasticsan.VolumeSnapshotsClientListByVolumeGroupOptions) ElasticSanVolumeSnapshotPager
+}
+
+type elasticSanVolumeSnapshotClient struct {
+	client *armelasticsan.VolumeSnapshotsClient
+}
+
+func (c *elasticSanVolumeSnapshotClient) Get(ctx context.Context, resourceGroupName string, elasticSanName string, volumeGroupName string, snapshotName string, options *armelasticsan.VolumeSnapshotsClientGetOptions) (armelasticsan.VolumeSnapshotsClientGetResponse, error) {
+	return c.client.Get(ctx, resourceGroupName, elasticSanName, volumeGroupName, snapshotName, options)
+}
+
+func (c *elasticSanVolumeSnapshotClient) ListByVolumeGroup(ctx context.Context, resourceGroupName string, elasticSanName string, volumeGroupName string, options *armelasticsan.VolumeSnapshotsClientListByVolumeGroupOptions) ElasticSanVolumeSnapshotPager {
+	return c.client.NewListByVolumeGroupPager(resourceGroupName, elasticSanName, volumeGroupName, options)
+}
+
+// NewElasticSanVolumeSnapshotClient creates a new ElasticSanVolumeSnapshotClient from the Azure SDK client.
+func NewElasticSanVolumeSnapshotClient(client *armelasticsan.VolumeSnapshotsClient) ElasticSanVolumeSnapshotClient {
+	return &elasticSanVolumeSnapshotClient{client: client}
+}

sources/azure/manual/adapters.go

@@ -15,6 +15,7 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/msi/armmsi"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v9"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/postgresql/armpostgresqlflexibleservers/v5"
+	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/elasticsan/armelasticsan"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources/v2"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/sql/armsql/v2"
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v3"
@@ -412,6 +413,11 @@ func Adapters(ctx context.Context, subscriptionID string, regions []string, cred
 			return nil, fmt.Errorf("failed to create snapshots client: %w", err)
 		}
 
+		elasticSanVolumeSnapshotsClient, err := armelasticsan.NewVolumeSnapshotsClient(subscriptionID, cred, nil)
+		if err != nil {
+			return nil, fmt.Errorf("failed to create elastic san volume snapshots client: %w", err)
+		}
+
 		sharedGalleryImagesClient, err := armcompute.NewSharedGalleryImagesClient(subscriptionID, cred, nil)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create shared gallery images client: %w", err)
@@ -692,6 +698,10 @@ func Adapters(ctx context.Context, subscriptionID string, regions []string, cred
 					clients.NewSnapshotsClient(snapshotsClient),
 					resourceGroupScopes,
 				), cache),
+				sources.WrapperToAdapter(NewElasticSanVolumeSnapshot(
+					clients.NewElasticSanVolumeSnapshotClient(elasticSanVolumeSnapshotsClient),
+					resourceGroupScopes,
+				), cache),
 			)
 		}
 
@@ -780,6 +790,7 @@ func Adapters(ctx context.Context, subscriptionID string, regions []string, cred
 			sources.WrapperToAdapter(NewComputeGallery(nil, placeholderResourceGroupScopes), noOpCache),
 			sources.WrapperToAdapter(NewComputeGalleryImage(nil, placeholderResourceGroupScopes), noOpCache),
 			sources.WrapperToAdapter(NewComputeSnapshot(nil, placeholderResourceGroupScopes), noOpCache),
+			sources.WrapperToAdapter(NewElasticSanVolumeSnapshot(nil, placeholderResourceGroupScopes), noOpCache),
 			sources.WrapperToAdapter(NewComputeSharedGalleryImage(nil, subscriptionID), noOpCache),
 			sources.WrapperToAdapter(NewNetworkPrivateEndpoint(nil, placeholderResourceGroupScopes), noOpCache),
 		)