Renderer sometimes doesn't set skin cluster index input

[ksuprynowicz]

It happens on drawIndexed with shaders model_deformeddq.vert and model.frag.

ERROR: [-862178626][VUID-VkGraphicsPipelineCreateInfo-Input-07904] : vkCreateGraphicsPipelines(): pCreateInfos[0].pVertexInputState->pVertexAttributeDescriptions does not have a Location 5 but vertex shader has an input variable at that Location. (This can be valid if either the vertexAttributeRobustness or maintenance9 feature is enabled).
The Vulkan spec states: If the vertexAttributeRobustness feature is not enabled, and the maintenance9 feature is not enabled, and the pipeline is being created with vertex input state and pVertexInputState is not dynamic, then all variables with the Input storage class decorated with Location in the Vertex Execution Model OpEntryPoint must contain a location in VkVertexInputAttributeDescription::location (https://docs.vulkan.org/spec/latest/chapters/pipelines.html#VUID-VkGraphicsPipelineCreateInfo-Input-07904)

[ksuprynowicz]

Skin cluster weight is missing too:

ERROR: [-862178626][VUID-VkGraphicsPipelineCreateInfo-Input-07904] : vkCreateGraphicsPipelines(): pCreateInfos[0].pVertexInputState->pVertexAttributeDescriptions does not have a Location 6 but vertex shader has an input variable at that Location. (This can be valid if either the vertexAttributeRobustness or maintenance9 feature is enabled).
The Vulkan spec states: If the vertexAttributeRobustness feature is not enabled, and the maintenance9 feature is not enabled, and the pipeline is being created with vertex input state and pVertexInputState is not dynamic, then all variables with the Input storage class decorated with Location in the Vertex Execution Model OpEntryPoint must contain a location in VkVertexInputAttributeDescription::location (https://docs.vulkan.org/spec/latest/chapters/pipelines.html#VUID-VkGraphicsPipelineCreateInfo-Input-07904)

[ksuprynowicz]

I added a check here:

void ModelMeshPartPayload::bindMesh(gpu::Batch& batch) {
    batch.setIndexBuffer(gpu::UINT32, (_drawMesh->getIndexBuffer()._buffer), 0);
    batch.setInputFormat((_drawMesh->getVertexFormat()));
    if (_isSkinned || _isBlendShaped) {
        auto attributeMap = _drawMesh->getVertexFormat()->getAttributes();
        Q_ASSERT(attributeMap.contains(GPU_ATTR_SKIN_CLUSTER_INDEX));
        Q_ASSERT(attributeMap.contains(GPU_ATTR_SKIN_CLUSTER_WEIGHT));
    }

It turns out that the issue happens when _isSkinned is false, _isBlendShaped is true and _prevUseDualQuaternionSkinning is true.