Skip to content

Commit 8c035be

Browse files
committed
fix missing subtitles for some voicelines
1 parent 5f1d3ec commit 8c035be

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

DataTool/FindLogic/Combo.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ public class VoiceLineInstanceInfo {
210210
public ulong VoiceStimulus;
211211
public ulong[] Conversations;
212212
public ulong Subtitle;
213-
public ulong SubtitleRuntime;
214213
public HashSet<ulong> SoundFiles;
215214

216215
public STUCriteriaContainer? m_criteria;
@@ -1052,11 +1051,14 @@ public static ComboInfo Find(ComboInfo info, ulong guid, Dictionary<ulong, ulong
10521051
voiceLineInstanceInfo.VoiceStimulus = voiceLineInstance.m_voiceLineRuntime.m_stimulus;
10531052
voiceLineInstanceInfo.ExternalSound = voiceLineInstance.m_voiceLineRuntime.m_externalSound;
10541053
voiceLineInstanceInfo.Conversations = voiceLineInstance.m_voiceLineRuntime.m_BD1B6F64?.Select(x => x.GUID.GUID).ToArray();
1055-
voiceLineInstanceInfo.SubtitleRuntime = voiceLineInstance.m_voiceLineRuntime.m_6148094F;
10561054
voiceLineInstanceInfo.m_criteria = voiceLineInstance.m_voiceLineRuntime.m_criteria;
10571055
voiceLineInstanceInfo.m_weight = voiceLineInstance.m_voiceLineRuntime.m_weight;
10581056
Find(info, voiceLineInstanceInfo.ExternalSound, replacements, context);
1059-
Find(info, voiceLineInstanceInfo.SubtitleRuntime, replacements, context);
1057+
1058+
if (voiceLineInstanceInfo.Subtitle == 0) {
1059+
voiceLineInstanceInfo.Subtitle = voiceLineInstance.m_voiceLineRuntime.m_6148094F;
1060+
Find(info, voiceLineInstanceInfo.Subtitle, replacements, context);
1061+
}
10601062
} else {
10611063
Console.Out.WriteLine("[DataTool.FindLogic.Combo]: ERROR: voice data container was null (please contact the developers)");
10621064
if (Debugger.IsAttached) {

DataTool/SaveLogic/Combo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public static void SaveVoiceLineInstance(
105105
var subtitleStr = subtitle.Trim().TrimEnd('.');
106106
if (soundSet.Count > 1) {
107107
realPath = Path.Combine(realPath, GetValidFilename(subtitleStr));
108-
WriteFile(string.Join("\n", subtitle), Path.Combine(realPath, $"{teResourceGUID.LongKey(voiceLineInstanceInfo.Subtitle):X8}-{teResourceGUID.LongKey(voiceLineInstanceInfo.SubtitleRuntime):X8}-subtitles.txt"));
108+
WriteFile(string.Join("\n", subtitle), Path.Combine(realPath, $"{teResourceGUID.LongKey(voiceLineInstanceInfo.Subtitle):X8}-subtitles.txt"));
109109
} else if (soundSet.Count == 1) {
110110
try {
111111
if (subtitleAsSound) {

DataTool/Static/GUIDNames.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ D8,078,Turret/EnemyTurretSeen,1
154154
69B,078,Hack,1
155155
69C,078,Hack,1
156156
69D,078,StealthActivate,1
157-
69E,078,YourWelcome,1
157+
69E,078,YoureWelcome,1
158158
6A1,078,Laugh,1
159159
6A4,078,Junkenstein,1
160160
6A5,078,Junkenstein,1

0 commit comments

Comments
 (0)