custom to user assertion

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com>

Author: yesnault

README.md

@@ -39,7 +39,7 @@ Venom is a CLI (Command Line Interface) that aims to create, manage and run your
   - [Assertions](#assertions)
     - [Keywords](#keywords)
       - [`Must` keywords](#must-keywords)
-      - [Custom assertions](#custom-assertions)
+      - [User assertions](#user-assertions)
     - [Using logical operators](#using-logical-operators)
 - [Write and run your first test suite](#write-and-run-your-first-test-suite)
 - [Export tests report](#export-tests-report)
@@ -696,9 +696,9 @@ Example:
   # Remaining steps in this context will not be executed
 ```
 
-#### Custom assertions
+#### User assertions
 
-It is possible to use the [user defined executors syntax](#user-defined-executors) and prefixing your executor name with `Should` to create a new custom assertion keyword. 
+It is possible to use the [user defined executors syntax](#user-defined-executors) and prefixing your executor name with `Should` to create a new "user assertion" keyword. 
 
 Example:
 ```yml
@@ -712,7 +712,7 @@ steps:
 
 You may also include additional steps like a regular user defined executor.
 
-Custom assertions are executed in an entirely clean context, containing only the following variables:
+User assertions are executed in an entirely clean context, containing only the following variables:
 - `a`: the left operand
 - `b`: the (first) right operand
 - `argv`: the rights operands
@@ -723,7 +723,7 @@ input:
   test: "{{.argv.argv1}}"
 ```
 
-To call a registered custom assertions, just use its registered name in the `assertions` array, like any built-in assertion keyword.
+To call a registered user assertions, just use its registered name in the `assertions` array, like any built-in assertion keyword.
 
 ```yml
 # test.yml

assertions/assertions.go

@@ -1509,8 +1509,8 @@ func getTimeFromString(in interface{}) (time.Time, error) {
 	return t, nil
 }
 
-// RegisterCustomAssertFunc registers a custom assertion function
-func RegisterCustomAssertFunc(name string, ux AssertFunc) error {
+// RegisterUserAssertFunc registers a user assertion function
+func RegisterUserAssertFunc(name string, ux AssertFunc) error {
 	if _, ok := assertMap[name]; ok {
 		return errors.Errorf("cannot redefine existing assertion %q", name)
 	}

assertions/assertions_test.go

@@ -2439,7 +2439,7 @@ func TestShouldNotJSONEqual(t *testing.T) {
 	}
 }
 
-func TestRegisterCustomAssertFunc(t *testing.T) {
+func TestRegisterUserAssertFunc(t *testing.T) {
 	var assertFunc AssertFunc
 
 	tests := []struct {
@@ -2465,9 +2465,9 @@ func TestRegisterCustomAssertFunc(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			err := RegisterCustomAssertFunc(tt.actual, assertFunc)
+			err := RegisterUserAssertFunc(tt.actual, assertFunc)
 			if (err != nil) != tt.wantErr {
-				t.Errorf("RegisterCustomAssertFunc() error = %v, wantErr %v", err, tt.wantErr)
+				t.Errorf("RegisterUserAssertFunc() error = %v, wantErr %v", err, tt.wantErr)
 			}
 		})
 	}

venom.go

@@ -285,7 +285,7 @@ func (v *Venom) registerUserExecutors(ctx context.Context) error {
 		if strings.HasPrefix(ux.Executor, "Should") {
 			err = v.registerUserAssertFunc(ctx, ux.Executor)
 			if err != nil {
-				return errors.Wrapf(err, "unable to register user executor %q from file %q as custom assertion", ux.Executor, f)
+				return errors.Wrapf(err, "unable to register user executor %q from file %q as user assertion", ux.Executor, f)
 			}
 		}
 	}
@@ -299,7 +299,7 @@ func (v *Venom) registerUserAssertFunc(ctx context.Context, name string) error {
 		return errors.Wrapf(err, "unable to load user executor %q", name)
 	}
 
-	err = assertions.RegisterCustomAssertFunc(name, func(actual interface{}, expected ...interface{}) error {
+	err = assertions.RegisterUserAssertFunc(name, func(actual interface{}, expected ...interface{}) error {
 		// Prepare a minimal context in which the user executor can be run
 		// We only need to register the operands in the var set
 		// as parent contexts will already have been templated
@@ -325,7 +325,7 @@ func (v *Venom) registerUserAssertFunc(ctx context.Context, name string) error {
 			}
 			return errors.New(strings.Join(msg, "\n"))
 		} else if err != nil {
-			return errors.Wrapf(err, "custom assertion failed during execution")
+			return errors.Wrapf(err, "user assertion failed during execution")
 		}
 
 		return nil