manifests: quote the "{node,pod}_name" Jinja variables in YAML

Jinja is not aware of what it is templating. So it does not know that we
want to set a string in YAML, or how to quote that.

Luckily, we already ensure that the node name is a valid DNS name. The
form of the pod name is even more strict. So they cannot contain quotes
that could break our YAML. Still, a node name "1" would be interpreted
as a plain number in YAML. We always want a YAML string.

Quote the value in the template.

In this case, this is safe, because we know that the node name and the
pod name only contain certain characters.

Author: thom311

manifests/host-pod.yaml.j2

@@ -2,17 +2,17 @@ apiVersion: v1
 kind: Pod
 metadata:
   namespace: {{ name_space }}
-  name: {{ pod_name }}
+  name: "{{ pod_name }}"
   labels:
     tft-tests: "{{ index }}"
     tft-port: "{{ port }}"
 spec:
   hostNetwork: true
   dnsPolicy: ClusterFirstWithHostNet
   nodeSelector:
-    kubernetes.io/hostname: {{ node_name }}
+    kubernetes.io/hostname: "{{ node_name }}"
   containers:
-  - name: {{ pod_name }}
+  - name: "{{ pod_name }}"
     image: {{ test_image }}
     command: {{ command }}
     args: {{ args }}

manifests/pod-secondary-network.yaml.j2

@@ -2,17 +2,17 @@ apiVersion: v1
 kind: Pod
 metadata:
   namespace: {{ name_space }}
-  name: {{ pod_name }}
+  name: "{{ pod_name }}"
   labels:
     tft-tests: "{{ index }}"
     tft-port: "{{ port }}"
   annotations:
     k8s.v1.cni.cncf.io/networks: {{ secondary_network_nad }}
 spec:
   nodeSelector:
-    kubernetes.io/hostname: {{ node_name }}
+    kubernetes.io/hostname: "{{ node_name }}"
   containers:
-  - name: {{ pod_name }}
+  - name: "{{ pod_name }}"
     image: {{ test_image }}
     command: {{ command }}
     args: {{ args }}

manifests/pod.yaml.j2

@@ -2,15 +2,15 @@ apiVersion: v1
 kind: Pod
 metadata:
   namespace: {{ name_space }}
-  name: {{ pod_name }}
+  name: "{{ pod_name }}"
   labels:
     tft-tests: "{{ index }}"
     tft-port: "{{ port }}"
 spec:
   nodeSelector:
-    kubernetes.io/hostname: {{ node_name }}
+    kubernetes.io/hostname: "{{ node_name }}"
   containers:
-  - name: {{ pod_name }}
+  - name: "{{ pod_name }}"
     image: {{ test_image }}
     command: {{ command }}
     args: {{ args }}

manifests/sriov-pod.yaml.j2

@@ -2,7 +2,7 @@ apiVersion: v1
 kind: Pod
 metadata:
   namespace: {{ name_space }}
-  name: {{ pod_name }}
+  name: "{{ pod_name }}"
   annotations: {% if not use_secondary_network %}
     v1.multus-cni.io/default-network: {{ default_network }} {% else %}
     k8s.v1.cni.cncf.io/networks: {{ secondary_network_nad }} {% endif %}
@@ -11,9 +11,9 @@ metadata:
     tft-port: "{{ port }}"
 spec:
   nodeSelector:
-    kubernetes.io/hostname: {{ node_name }}
+    kubernetes.io/hostname: "{{ node_name }}"
   containers:
-  - name: {{ pod_name }}
+  - name: "{{ pod_name }}"
     image: {{ test_image }}
     command: {{ command }}
     args: {{ args }}

manifests/tools-pod.yaml.j2

@@ -2,15 +2,15 @@ apiVersion: v1
 kind: Pod
 metadata:
   namespace: {{ name_space }}
-  name: {{ pod_name }}
+  name: "{{ pod_name }}"
   labels:
     tft-tests: "{{ index }}"
 spec:
   nodeSelector:
-    kubernetes.io/hostname: {{ node_name }}
+    kubernetes.io/hostname: "{{ node_name }}"
   hostNetwork: true
   containers:
-  - name: {{ pod_name }}
+  - name: "{{ pod_name }}"
     image: {{ test_image }}
     command: {{ command }}
     args: {{ args }}