Fix sos-search-commands tools issue

when output is empty, the Matches slice in SearchCommandsResult was nil.
When marshaled and returned via MCP, this resulted in "matches": null
in the JSON output, causing schema validation failures.

This fix ensures that even when no commands are found, the JSON output
always contains "matches": [] and conforms to the MCP tool schema.

Signed-off-by: Meina-rh <meinli@redhat.com>

Author: Meina-rh

.github/workflows/e2e.yml

@@ -24,8 +24,6 @@ jobs:
         include:
           - {mode: "live-cluster"}
           - {mode: "offline"}
-    env:
-      JOB_NAME: "${{ matrix.mode }}"
     steps:
       - name: Check out code into the Go module directory
         uses: actions/checkout@v4
@@ -89,7 +87,7 @@ jobs:
         if: always() && matrix.mode == 'live-cluster'
         uses: actions/upload-artifact@v4
         with:
-          name: kind-logs-e2e-${{ github.run_id }}
+          name: kind-logs-e2e-${{ matrix.mode }}-${{ github.run_id }}
           path: /tmp/kind/logs
           if-no-files-found: ignore
 

pkg/sosreport/mcp/commands.go

@@ -5,6 +5,7 @@ import (
 	"os"
 	"path/filepath"
 	"regexp"
+
 	"github.com/ovn-kubernetes/ovn-kubernetes-mcp/pkg/sosreport/types"
 )
 
@@ -122,7 +123,9 @@ func searchCommands(sosreportPath, pattern string, maxResults int) (types.Search
 		return types.SearchCommandsResult{}, fmt.Errorf("invalid search pattern: %w", err)
 	}
 
-	var result types.SearchCommandsResult
+	result := types.SearchCommandsResult{
+		Matches: []types.CommandMatch{},
+	}
 	if maxResults <= 0 {
 		maxResults = defaultResultLimit
 	}