treewide: Remove Windows service handling.

This is one missed bit of the old Windows support.

Interestingly, ovn-dbctl and ovn-trace didn't stop their services.

Fixes: accc3e7 ("treewide: Remove shards of Windows support.")
Acked-by: Alin Gabriel Serdean <aserdean@ovn.org>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Signed-off-by: Mark Michelson <mmichels@redhat.com>

Author: igsilya

br-controller/ovn-br-controller.c

@@ -131,7 +131,6 @@ main(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
 
     ovs_cmdl_proctitle_init(argc, argv);
     ovn_set_program_name(argv[0]);
-    service_start(&argc, &argv);
     char *ovs_remote = parse_options(argc, argv);
     fatal_ignore_sigpipe();
 
@@ -322,9 +321,6 @@ main(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
         ovsdb_idl_track_clear(ovs_idl_loop.idl);
 
         poll_block();
-        if (should_service_stop()) {
-            exit_args.exiting = true;
-        }
     }
 
     engine_set_context(NULL);
@@ -333,7 +329,6 @@ main(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
     free(ovs_remote);
     ovn_exit_args_finish(&exit_args);
     unixctl_server_destroy(unixctl);
-    service_stop();
     exit(0);
 }
 

controller-vtep/ovn-controller-vtep.c

@@ -115,7 +115,6 @@ main(int argc, char *argv[])
 
     ovs_cmdl_proctitle_init(argc, argv);
     ovn_set_program_name(argv[0]);
-    service_start(&argc, &argv);
     parse_options(argc, argv);
     fatal_ignore_sigpipe();
 
@@ -229,9 +228,6 @@ main(int argc, char *argv[])
         ovsdb_idl_loop_commit_and_wait(&vtep_idl_loop);
         ovsdb_idl_loop_commit_and_wait(&ovnsb_idl_loop);
         poll_block();
-        if (should_service_stop()) {
-            exiting = true;
-        }
     }
 
     /* It's time to exit.  Clean up the databases. */
@@ -267,7 +263,6 @@ main(int argc, char *argv[])
     free(ovnsb_remote);
     free(vtep_remote);
     free(default_db_);
-    service_stop();
 
     exit(retval);
 }

controller/ovn-controller.c

@@ -7459,7 +7459,6 @@ main(int argc, char *argv[])
 
     ovs_cmdl_proctitle_init(argc, argv);
     ovn_set_program_name(argv[0]);
-    service_start(&argc, &argv);
     char *ovs_remote = parse_options(argc, argv);
     fatal_ignore_sigpipe();
 
@@ -8386,9 +8385,6 @@ main(int argc, char *argv[])
         memory_wait();
         ovsrcu_quiesce_start();
         poll_block();
-        if (should_service_stop()) {
-            exit_args.exiting = true;
-        }
     }
 
     const struct ovsrec_open_vswitch_table *ovs_table =
@@ -8496,7 +8492,6 @@ main(int argc, char *argv[])
     free(cli_system_id);
     ovn_exit_args_finish(&exit_args);
     unixctl_server_destroy(unixctl);
-    service_stop();
     ovsrcu_exit();
     dns_resolve_destroy();
     route_exchange_destroy();

ic/ovn-ic.c

@@ -3444,7 +3444,6 @@ main(int argc, char *argv[])
     fatal_ignore_sigpipe();
     ovs_cmdl_proctitle_init(argc, argv);
     ovn_set_program_name(argv[0]);
-    service_start(&argc, &argv);
     parse_options(argc, argv);
 
     daemonize_start(false, false);
@@ -4063,9 +4062,6 @@ main(int argc, char *argv[])
         }
 
         poll_block();
-        if (should_service_stop()) {
-            exiting = true;
-        }
     }
     inc_proc_ic_cleanup();
 
@@ -4075,7 +4071,6 @@ main(int argc, char *argv[])
     ovsdb_idl_loop_destroy(&ovninb_idl_loop);
     ovsdb_idl_loop_destroy(&ovnisb_idl_loop);
     ovsdb_idl_loop_destroy(&ovnisb_unlocked_idl_loop);
-    service_stop();
 
     exit(res);
 }

northd/ovn-northd.c

@@ -835,7 +835,6 @@ main(int argc, char *argv[])
     fatal_ignore_sigpipe();
     ovs_cmdl_proctitle_init(argc, argv);
     ovn_set_program_name(argv[0]);
-    service_start(&argc, &argv);
     parse_options(argc, argv, &state.paused, &n_threads);
 
     daemonize_start(false, false);
@@ -1217,9 +1216,6 @@ main(int argc, char *argv[])
 
         stopwatch_stop(NORTHD_LOOP_STOPWATCH_NAME, time_msec());
         poll_block();
-        if (should_service_stop()) {
-            exit_args.exiting = true;
-        }
         stopwatch_start(NORTHD_LOOP_STOPWATCH_NAME, time_msec());
     }
     inc_proc_northd_cleanup();
@@ -1228,7 +1224,6 @@ main(int argc, char *argv[])
     ovsdb_idl_loop_destroy(&ovnsb_idl_loop);
     ovn_exit_args_finish(&exit_args);
     unixctl_server_destroy(unixctl);
-    service_stop();
     run_update_worker_pool(0);
     ovsrcu_exit();
 

utilities/ovn-dbctl.c

@@ -106,7 +106,7 @@ static char * OVS_WARN_UNUSED_RESULT main_loop(
     struct ctl_command *commands, size_t n_commands,
     struct ovsdb_idl *idl, const struct timer *);
 static void server_loop(const struct ovn_dbctl_options *dbctl_options,
-                        struct ovsdb_idl *idl, int argc, char *argv[]);
+                        struct ovsdb_idl *idl);
 static void ovn_dbctl_exit(int status);
 
 static void
@@ -209,7 +209,7 @@ ovn_dbctl_main(int argc, char *argv[],
     set_idl_probe_interval(idl, db, DEFAULT_UTILS_PROBE_INTERVAL_MSEC);
 
     if (daemon_mode) {
-        server_loop(dbctl_options, idl, argc, argv_);
+        server_loop(dbctl_options, idl);
     } else {
         struct ctl_command *commands;
         size_t n_commands;
@@ -1124,12 +1124,11 @@ update_inactivity_probe(struct server_cmd_run_ctx *ctx)
 
 static void
 server_loop(const struct ovn_dbctl_options *dbctl_options,
-            struct ovsdb_idl *idl, int argc, char *argv[])
+            struct ovsdb_idl *idl)
 {
     struct unixctl_server *server = NULL;
     bool exiting = false;
 
-    service_start(&argc, &argv);
     daemonize_start(false, false);
 
     char *abs_unixctl_path = get_abs_unix_ctl_path(unixctl_path);

utilities/ovn-trace.c

@@ -106,7 +106,6 @@ int
 main(int argc, char *argv[])
 {
     ovn_set_program_name(argv[0]);
-    service_start(&argc, &argv);
     fatal_ignore_sigpipe();
     vlog_set_levels_from_string_assert("reconnect:warn");