controller: Remove Advertised_Route_Status table.

This reverts commit 7031ffc.

Advertised_Route_Status has no current consumer. ovn-heater
measurements also confirmed that publishing status rows adds Southbound
database work. Remove the table while its consumers and scalability
requirements are reconsidered.

Signed-off-by: Dmitrii Shcherbakov <dmitrii.s@protonmail.com>
Signed-off-by: Ales Musil <amusil@redhat.com>

Author: Dmitrii Shcherbakov

NEWS

@@ -1,8 +1,5 @@
 Post v26.03.0
 -------------
-   - New Southbound Advertised_Route_Status table has been added. This is used
-     in order for ovn-controller instances to know the state of advertised
-     routes amongst each other.
    - Logical_Router_Port: Added a new "options:dhcpv4_primary_ip" key
      that selects which of the port's IPv4 addresses ovn-northd uses as
      the relay agent address (giaddr) in relayed DHCP packets.  When

controller/chassis.c

@@ -1181,26 +1181,14 @@ chassis_cleanup(struct ovsdb_idl_txn *ovs_idl_txn,
                 struct ovsdb_idl_txn *ovnsb_idl_txn,
                 const struct ovsrec_open_vswitch_table *ovs_table,
                 const struct sbrec_chassis *chassis_rec,
-                const struct sbrec_chassis_private *chassis_private_rec,
-                const struct sbrec_advertised_route_status_table *status_table)
+                const struct sbrec_chassis_private *chassis_private_rec)
 {
-    const char *chassis_name = get_ovs_chassis_id(ovs_table);
-    bool has_route_status = false;
-    if (status_table && chassis_name) {
-        const struct sbrec_advertised_route_status *status;
-        SBREC_ADVERTISED_ROUTE_STATUS_TABLE_FOR_EACH (status, status_table) {
-            if (!strcmp(status->chassis_name, chassis_name)) {
-                has_route_status = true;
-                break;
-            }
-        }
-    }
-
     if (!chassis_rec && !chassis_private_rec &&
-            !is_chassis_idx_stored(ovs_table) && !has_route_status) {
+            !is_chassis_idx_stored(ovs_table)) {
         return true;
     }
 
+    const char *chassis_name = get_ovs_chassis_id(ovs_table);
     if (ovs_idl_txn) {
         ovsdb_idl_txn_add_comment(
             ovs_idl_txn,
@@ -1219,15 +1207,6 @@ chassis_cleanup(struct ovsdb_idl_txn *ovs_idl_txn,
         if (chassis_private_rec) {
             sbrec_chassis_private_delete(chassis_private_rec);
         }
-        if (status_table && chassis_name) {
-            const struct sbrec_advertised_route_status *status;
-            SBREC_ADVERTISED_ROUTE_STATUS_TABLE_FOR_EACH_SAFE (
-                status, status_table) {
-                if (!strcmp(status->chassis_name, chassis_name)) {
-                    sbrec_advertised_route_status_delete(status);
-                }
-            }
-        }
     }
     return false;
 }

controller/chassis.h

@@ -29,7 +29,6 @@ struct ovsrec_open_vswitch_table;
 struct sbrec_chassis;
 struct sbrec_chassis_table;
 struct sbrec_chassis_private_table;
-struct sbrec_advertised_route_status_table;
 struct sset;
 struct eth_addr;
 struct smap;
@@ -51,8 +50,7 @@ bool chassis_cleanup(struct ovsdb_idl_txn *ovs_idl_txn,
                      struct ovsdb_idl_txn *ovnsb_idl_txn,
                      const struct ovsrec_open_vswitch_table *,
                      const struct sbrec_chassis *,
-                     const struct sbrec_chassis_private *,
-                     const struct sbrec_advertised_route_status_table *);
+                     const struct sbrec_chassis_private *);
 bool chassis_get_mac(const struct sbrec_chassis *chassis,
                      const char *bridge_mapping,
                      struct eth_addr *chassis_mac);