Erroneous "Plan has changed" in terraform v2 orb apply

[Mark-Wood]

Since v2.5 of the terraform v2 orb, the plan generated at the apply step doesn't match the one generated in the plan.

It seems the plan pulled from the Github PR is appended with aaa\n---aaa, whereas the one generated in the apply step doesn't, so the comparison step fails.

We started noticing this recently in our https://github.com/ovotech/orion-onboarding-infra repo and has been temporarily fixed by reverting to version 2.4 of the orb (PR: https://github.com/ovotech/orion-onboarding-infra/pull/719).

@luigi-riefolo It looks like you were working in this area last month if you have time to investigate.

[samrumley88]

Thanks for the suggestion @Mark-Wood 🙏

We've (MIT Team) also started to encounter this issue recently on quite a few of our CI pipelines.

[raraujo-ovo]

We (RnR) are also encountering a similar issue in the Tardis services. Thanks for raising it Mark