Skip to content

Commit 7ddabe0

Browse files
committed
minor change to S3__Key_Generator
1 parent af79967 commit 7ddabe0

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

osbot_aws/aws/s3/S3__Key_Generator.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,7 @@ def create_path_elements__from_when(self, when=None, area: Safe_Id = None):
4141
if not when:
4242
when = self.path__for_date_time__now_utc()
4343
if when: # for the cases when path__for_date_time__now_utc returns and empty value
44-
if self.split_when:
45-
path_elements.extend(when.split('-'))
46-
else:
47-
path_elements.append(when)
44+
path_elements.append(when)
4845

4946

5047

@@ -71,7 +68,10 @@ def path__for_date_time(self, date_time):
7168
minute_block = self.calculate_minute_block(minute)
7269
path_components = []
7370
if self.use_date:
74-
path_components.append(date_path )
71+
if self.split_when:
72+
path_components.extend(date_path.split('-'))
73+
else:
74+
path_components.append(date_path )
7575
if self.use_hours:
7676
path_components.append(hour_path )
7777
if self.use_minutes:

tests/unit/aws/s3/test_S3__Key_Generator.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,31 +157,31 @@ def test_create_path_elements__from_when__with_area_and_split(self):
157157

158158
# Test split_when parameter
159159
_.split_when = True
160-
expected = ['root', 'server1', 'test-area', '2021','01','01/12/00']
160+
expected = ['root', 'server1', 'test-area', '2021-01-01/12/00']
161161
result = _.create_path_elements__from_when(when=when, area=area)
162162

163163
assert result == expected
164164

165165
# Test with no area but split_when
166166
_.split_when = True
167167
area = None
168-
expected = ['root', 'server1', '2021','01','01/12/00']
168+
expected = ['root', 'server1', '2021-01-01/12/00']
169169
result = _.create_path_elements__from_when(when=when, area=area)
170170
assert result == expected
171171

172172
# Test with use_when=False
173173
_.use_when = False
174-
area = Safe_Id('test-area')
174+
area = Safe_Id('test-area')
175175
expected = ['root', 'server1', 'test-area']
176-
result = _.create_path_elements__from_when(when=when, area=area)
176+
result = _.create_path_elements__from_when(when=when, area=area)
177177
assert result == expected
178178

179179
# Test with actual datetime path generation
180-
_.use_when = True
180+
_.use_when = True
181181
_.split_when = True
182182
now_path = _.path__for_date_time__now_utc()
183183
result = _.create_path_elements__from_when(area=area)
184-
assert len(result) == len(now_path.split('/')) + 3 # root, server1, area + split path
184+
assert len(result) == len(now_path.split('/')) - 1
185185
assert result[0] == 'root'
186186
assert result[1] == 'server1'
187187
assert result[2] == 'test-area'

0 commit comments

Comments
 (0)