Skip to content

Commit c516bdf

Browse files
authored
Remove deprecated ReflectionProperty::setAccessible() for php 8.5 (#1046)
1 parent 1ce5500 commit c516bdf

2 files changed

Lines changed: 2 additions & 11 deletions

File tree

src/Events/DispatchAudit.php

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,7 @@ public function __unserialize(array $values): void
8484
*/
8585
protected function setModelPropertyValue(ReflectionClass $reflection, string $name, $value): void
8686
{
87-
$property = $reflection->getProperty($name);
88-
89-
$property->setAccessible(true);
90-
91-
$property->setValue($this->model, $value);
87+
$reflection->getProperty($name)->setValue($this->model, $value);
9288
}
9389

9490
/**
@@ -99,10 +95,6 @@ protected function setModelPropertyValue(ReflectionClass $reflection, string $na
9995
*/
10096
protected function getModelPropertyValue(ReflectionClass $reflection, string $name)
10197
{
102-
$property = $reflection->getProperty($name);
103-
104-
$property->setAccessible(true);
105-
106-
return $property->getValue($this->model);
98+
return $reflection->getProperty($name)->getValue($this->model);
10799
}
108100
}

tests/Unit/AuditableTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -936,7 +936,6 @@ public function test_it_fails_to_transition_when_the_audit_auditable_id_type_doe
936936
$auditReflection = new ReflectionClass($audit);
937937

938938
$auditCastsProperty = $auditReflection->getProperty('casts');
939-
$auditCastsProperty->setAccessible(true);
940939
$auditCastsProperty->setValue($audit, [
941940
'old_values' => 'json',
942941
'new_values' => 'json',

0 commit comments

Comments
 (0)