Skip to content

Commit 578dd19

Browse files
authored
Merge pull request #4129 from owncloud/feature/apply_1_to_uploads_name_conflicts
[FEATURE REQUEST] Apply (1) to uploads' name conflicts
2 parents 958f178 + 9cce8d5 commit 578dd19

3 files changed

Lines changed: 22 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ Summary
2929
* Enhancement - Prevent http traffic with branding options: [#4066](https://github.com/owncloud/android/issues/4066)
3030
* Enhancement - Unit tests for datasources classes - Part 2: [#4071](https://github.com/owncloud/android/issues/4071)
3131
* Enhancement - Respect app_providers_appsUrl value from capabilities: [#4075](https://github.com/owncloud/android/issues/4075)
32+
* Enhancement - Apply (1) to uploads' name conflicts: [#4079](https://github.com/owncloud/android/issues/4079)
3233
* Enhancement - Support "per app" language change on Android 13+: [#4082](https://github.com/owncloud/android/issues/4082)
3334
* Enhancement - Align Sharing icons with other platforms: [#4101](https://github.com/owncloud/android/issues/4101)
3435

@@ -199,6 +200,16 @@ Details
199200
https://github.com/owncloud/android/issues/4075
200201
https://github.com/owncloud/android/pull/4113
201202

203+
* Enhancement - Apply (1) to uploads' name conflicts: [#4079](https://github.com/owncloud/android/issues/4079)
204+
205+
When new files were uploaded manually to pC, shared from a 3rd party app or text shared with oC
206+
name conflict happens, (2) was added to the file name instead of (1).
207+
208+
Right now if we upload a file with a repeated name, the new file name will end with (1).
209+
210+
https://github.com/owncloud/android/issues/4079
211+
https://github.com/owncloud/android/pull/4129
212+
202213
* Enhancement - Support "per app" language change on Android 13+: [#4082](https://github.com/owncloud/android/issues/4082)
203214

204215
The locales_config.xml file has been created for the application to detect the language that

changelog/unreleased/4129

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
Enhancement: Apply (1) to uploads' name conflicts
2+
3+
When new files were uploaded manually to pC, shared from a 3rd party app or text shared with oC
4+
name conflict happens, (2) was added to the file name instead of (1).
5+
6+
Right now if we upload a file with a repeated name, the new file name will end with (1).
7+
8+
9+
https://github.com/owncloud/android/issues/4079
10+
https://github.com/owncloud/android/pull/4129

owncloudApp/src/main/java/com/owncloud/android/utils/RemoteFileUtils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class RemoteFileUtils {
5252
substring(0, pos)
5353
}
5454
}
55-
var count = 2
55+
var count = 1
5656
do {
5757
suffix = " ($count)"
5858
checkExistsFile = if (pos >= 0) {

0 commit comments

Comments
 (0)