Merge pull request #4790 from mykh-hailo/fix/scrollable-space-header

[FIX] Spaces' root folder in landscape has no room for the list of files

Author: jesmrec

changelog/unreleased/4790

@@ -0,0 +1,6 @@
+Bugfix: Reduce space header size after rotating device
+
+The space header height has been reduced in landscape orientation.
+
+https://github.com/owncloud/android/issues/4625
+https://github.com/owncloud/android/pull/4790

owncloudApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListFragment.kt

@@ -29,6 +29,7 @@ import android.annotation.SuppressLint
 import android.content.Context
 import android.content.Intent
 import android.content.res.ColorStateList
+import android.content.res.Configuration
 import android.graphics.drawable.Drawable
 import android.net.Uri
 import android.os.Build
@@ -327,6 +328,27 @@ class MainFileListFragment : Fragment(),
         subscribeToViewModels()
     }
 
+    override fun onConfigurationChanged(newConfig: Configuration) {
+        super.onConfigurationChanged(newConfig)
+        updateConfigDependentSizes()
+    }
+
+    private fun updateConfigDependentSizes() {
+        val cardSize = resources.getDimensionPixelSize(R.dimen.spaces_header_card_height)
+        binding.spaceHeader.spaceHeaderCard.layoutParams.apply {
+            width = cardSize
+            height = cardSize
+        }
+        binding.spaceHeader.spaceHeaderCard.requestLayout()
+
+        val iconSize = resources.getDimensionPixelSize(R.dimen.empty_icon_size)
+        binding.emptyDataParent.listEmptyDatasetIcon.layoutParams.apply {
+            width = iconSize
+            height = iconSize
+        }
+        binding.emptyDataParent.listEmptyDatasetIcon.requestLayout()
+    }
+
     override fun onResume() {
         super.onResume()
         if (browserOpened) {

owncloudApp/src/main/res/layout/item_empty_dataset.xml

@@ -9,8 +9,8 @@
 
     <ImageView
         android:id="@+id/list_empty_dataset_icon"
-        android:layout_width="72dp"
-        android:layout_height="72dp"
+        android:layout_width="@dimen/empty_icon_size"
+        android:layout_height="@dimen/empty_icon_size"
         app:layout_constraintBottom_toTopOf="@id/list_empty_dataset_title"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"

owncloudApp/src/main/res/values-h640dp/dims.xml

@@ -29,4 +29,5 @@
     <!-- Spaces -->
     <dimen name="spaces_thumbnail_height">172dp</dimen>
     <dimen name="spaces_header_card_height">100dp</dimen>
+    <dimen name="empty_icon_size">48dp</dimen>
 </resources>

owncloudApp/src/main/res/values-h740dp/dims.xml

@@ -32,4 +32,5 @@
     <dimen name="spaces_header_card_height">150dp</dimen>
     <dimen name="spaces_margin_horizontal">30dp</dimen>
     <dimen name="spaces_margin_vertical">20dp</dimen>
+    <dimen name="empty_icon_size">72dp</dimen>
 </resources>

owncloudApp/src/main/res/values-sw720dp/dims.xml

@@ -24,4 +24,5 @@
     <dimen name="spaces_header_card_height">150dp</dimen>
     <dimen name="spaces_margin_horizontal">50dp</dimen>
     <dimen name="spaces_margin_vertical">40dp</dimen>
+    <dimen name="empty_icon_size">72dp</dimen>
 </resources>

owncloudApp/src/main/res/values/dims.xml

@@ -88,4 +88,5 @@
 
     <!-- Accessibility dims -->
     <dimen name="icon_button_size">48dp</dimen>
+    <dimen name="empty_icon_size">36dp</dimen>
 </resources>