Fix url resolution for app provider

Fixes: #11296

Author: TheOneRing

changelog/unreleased/11296

@@ -0,0 +1,8 @@
+Bugfix: Fix url resolution for app provider
+
+We fixed a bug in the url resolution for the app provider.
+If owncloud is installed to a non root directory we computed a wrong url for the app provider urls.
+This could trigger a connection validation in the client, which intern triggered a request to the app provider.
+Reulting in an endless loop rendering the client unusable.
+
+https://github.com/owncloud/client/issues/11296

src/cmd/cmd.cpp

@@ -485,7 +485,7 @@ int main(int argc, char **argv)
                                     .value(QStringLiteral("capabilities"))
                                     .toObject();
                     qDebug() << "Server capabilities" << caps;
-                    ctx.account->setCapabilities(caps.toVariantMap());
+                    ctx.account->setCapabilities({ctx.account->url(), caps.toVariantMap()});
 
                     switch (ctx.account->serverSupportLevel()) {
                     case Account::ServerSupportLevel::Supported:

src/gui/accountmanager.cpp

@@ -285,7 +285,7 @@ AccountPtr AccountManager::loadAccountHelper(QSettings &settings)
 
     acc->_davUser = settings.value(davUserC()).toString();
     acc->_displayName = settings.value(davUserDisplyNameC()).toString();
-    acc->setCapabilities(settings.value(capabilitesC()).value<QVariantMap>());
+    acc->setCapabilities({acc->url(), settings.value(capabilitesC()).value<QVariantMap>()});
     acc->setDefaultSyncRoot(settings.value(defaultSyncRootC()).toString());
 
     // We want to only restore settings for that auth type and the user value

src/gui/fetchserversettings.cpp

@@ -56,7 +56,7 @@ void FetchServerSettingsJob::start()
             if (auto reply = job->reply()) {
                 _account->setHttp2Supported(reply->attribute(QNetworkRequest::Http2WasUsedAttribute).toBool());
             }
-            _account->setCapabilities(caps.toVariantMap());
+            _account->setCapabilities({_account->url(), caps.toVariantMap()});
             if (checkServerInfo()) {
                 auto *userJob = new JsonApiJob(_account, QStringLiteral("ocs/v2.php/cloud/user"), SimpleNetworkJob::UrlQuery{}, QNetworkRequest{}, this);
                 job->setAuthenticationJob(isAuthJob());
@@ -98,7 +98,7 @@ void FetchServerSettingsJob::runAsyncUpdates()
     };
 
     if (_account->capabilities().appProviders().enabled) {
-        auto *jsonJob = new JsonJob(_account, _account->url(), _account->capabilities().appProviders().appsUrl, "GET");
+        auto *jsonJob = new JsonJob(_account, _account->capabilities().appProviders().appsUrl, {}, "GET");
         connect(jsonJob, &JsonJob::finishedSignal, this, [jsonJob, this] { _account->setAppProvider(AppProvider{jsonJob->data()}); });
         jsonJob->start();
     }

src/libsync/account.cpp

@@ -61,7 +61,7 @@ QString Account::commonCacheDirectory()
 Account::Account(const QUuid &uuid, QObject *parent)
     : QObject(parent)
     , _uuid(uuid)
-    , _capabilities(QVariantMap())
+    , _capabilities({}, {})
     , _jobQueue(this)
     , _queueGuard(&_jobQueue)
     , _credentialManager(new CredentialManager(this))

src/libsync/appprovider.cpp

@@ -78,7 +78,7 @@ bool AppProvider::open(const AccountPtr &account, const QString &localPath, cons
     const auto &a = app(localPath);
     if (a.isValid()) {
         SimpleNetworkJob::UrlQuery query { { QStringLiteral("file_id"), QString::fromUtf8(fileId) } };
-        auto *job = new JsonJob(account, account->url(), account->capabilities().appProviders().openWebUrl, "POST", query);
+        auto *job = new JsonJob(account, account->capabilities().appProviders().openWebUrl, {}, "POST", query);
         QObject::connect(job, &JsonJob::finishedSignal, [account, job, localPath] {
             if (job->httpStatusCode() == 200) {
                 const auto url = QUrl(job->data().value(QStringLiteral("uri")).toString());

src/libsync/capabilities.cpp

@@ -14,23 +14,23 @@
 
 #include "capabilities.h"
 
-#include <QVariantMap>
 #include <QDebug>
+#include <QVariantMap>
 
 using namespace std::chrono;
 
 namespace OCC {
 
 
-Capabilities::Capabilities(const QVariantMap &capabilities)
+Capabilities::Capabilities(const QUrl &url, const QVariantMap &capabilities)
     : _capabilities(capabilities)
     , _fileSharingCapabilities(_capabilities.value(QStringLiteral("files_sharing")).toMap())
     , _fileSharingPublicCapabilities(_fileSharingCapabilities.value(QStringLiteral("public"), {}).toMap())
     , _tusSupport(_capabilities.value(QStringLiteral("files")).toMap().value(QStringLiteral("tus_support")).toMap())
     , _spaces(_capabilities.value(QStringLiteral("spaces")).toMap())
     , _status(_capabilities.value(QStringLiteral("core")).toMap().value(QStringLiteral("status")).toMap())
     , _appProviders(AppProviders::findVersion(
-          _capabilities.value(QStringLiteral("files")).toMap().value(QStringLiteral("app_providers")).toList(), QVersionNumber({1, 1, 0})))
+          url, _capabilities.value(QStringLiteral("files")).toMap().value(QStringLiteral("app_providers")).toList(), QVersionNumber({1, 1, 0})))
     , _filesSharing(_fileSharingCapabilities)
     , _migration(_capabilities.value(QStringLiteral("migration")).toMap())
 {
@@ -313,28 +313,28 @@ bool SpaceSupport::isValid() const
     return !version.isNull();
 }
 
-Capabilities::AppProviders::AppProviders(const QVariantMap &appProviders)
+Capabilities::AppProviders::AppProviders(const QUrl &baseUrl, const QVariantMap &appProviders)
     : enabled(appProviders.value(QStringLiteral("enabled")).toBool())
     , version(QVersionNumber::fromString(appProviders.value(QStringLiteral("version")).toString()))
-    , appsUrl(appProviders.value(QStringLiteral("apps_url")).toString())
-    , openUrl(appProviders.value(QStringLiteral("open_url")).toString())
-    , newUrl(appProviders.value(QStringLiteral("new_url")).toString())
-    , openWebUrl(appProviders.value(QStringLiteral("open_web_url")).toString())
+    , appsUrl(baseUrl.resolved(appProviders.value(QStringLiteral("apps_url")).toUrl()))
+    , openUrl(baseUrl.resolved(appProviders.value(QStringLiteral("open_url")).toUrl()))
+    , newUrl(baseUrl.resolved(appProviders.value(QStringLiteral("new_url")).toUrl()))
+    , openWebUrl(baseUrl.resolved(appProviders.value(QStringLiteral("open_web_url")).toUrl()))
 {
 }
 
+
 const Capabilities::AppProviders &Capabilities::appProviders() const
 {
     return _appProviders;
 }
 
-Capabilities::AppProviders Capabilities::AppProviders::findVersion(const QVariantList &list, const QVersionNumber &v)
+Capabilities::AppProviders Capabilities::AppProviders::findVersion(const QUrl &baseUrl, const QVariantList &list, const QVersionNumber &v)
 {
     auto it = std::find_if(list.cbegin(), list.cend(), [&v](const auto &it) {
         return QVersionNumber::fromString(it.toMap().value(QStringLiteral("version")).toString()) == v;
     });
-    return it != list.cend() ? Capabilities::AppProviders { it->toMap() }
-                             : Capabilities::AppProviders();
+    return it != list.cend() ? Capabilities::AppProviders{baseUrl, it->toMap()} : Capabilities::AppProviders{};
 }
 
 const FilesSharing &Capabilities::filesSharing() const

src/libsync/capabilities.h

@@ -144,19 +144,19 @@ class OWNCLOUDSYNC_EXPORT Capabilities
                 }
         */
         AppProviders() = default;
-        static AppProviders findVersion(const QVariantList &list, const QVersionNumber &v);
-        AppProviders(const QVariantMap &appProviders);
+        static AppProviders findVersion(const QUrl &baseUrl, const QVariantList &list, const QVersionNumber &v);
+        AppProviders(const QUrl &baseUrl, const QVariantMap &appProviders);
 
         bool enabled = false;
         QVersionNumber version;
-        QString appsUrl;
-        QString openUrl;
-        QString newUrl;
-        QString openWebUrl;
+        QUrl appsUrl;
+        QUrl openUrl;
+        QUrl newUrl;
+        QUrl openWebUrl;
     };
 
 
-    Capabilities(const QVariantMap &capabilities);
+    Capabilities(const QUrl &url, const QVariantMap &capabilities);
 
     bool shareAPI() const;
     bool sharePublicLink() const;

test/testlocaldiscovery.cpp

@@ -226,7 +226,7 @@ private slots:
         auto cap = TestUtils::testCapabilities();
         cap.insert(
             {{QStringLiteral("files"), QVariantMap{{QStringLiteral("blacklisted_files"), QVariantList{QStringLiteral(".foo"), QStringLiteral("bar")}}}}});
-        fakeFolder.account()->setCapabilities(cap);
+        fakeFolder.account()->setCapabilities({fakeFolder.account()->url(), cap});
         fakeFolder.localModifier().insert(QStringLiteral("C/.foo"));
         fakeFolder.localModifier().insert(QStringLiteral("C/bar"));
         fakeFolder.localModifier().insert(QStringLiteral("C/moo"));

test/testspacesmigration/testspacesmigration.cpp

@@ -52,7 +52,7 @@ private slots:
         auto cap = TestUtils::testCapabilities();
         cap[QStringLiteral("migration")] = QVariantMap{{QStringLiteral("space_migration"),
             QVariantMap{{QStringLiteral("enabled"), true}, {QStringLiteral("endpoint"), QStringLiteral("migration/spaces")}}}};
-        fakeFolder.account()->setCapabilities(cap);
+        fakeFolder.account()->setCapabilities({fakeFolder.account()->url(), cap});
 
 
         const QUrl personalUrl(