Fix expansion of selective sync tree (#10058)

Fixes a bug introduced in 8d0dd36.

Author: fmoc

changelog/unreleased/10058

@@ -0,0 +1,6 @@
+Bugfix: Fix configuration of selective sync from account settings
+
+We removed a superfluous check which caused the directory tree in the account settings window to no longer expand beyond the first level.
+The problem was introduced in 8d0dd36d2.
+
+https://github.com/owncloud/client/pull/10058

src/gui/accountsettings.cpp

@@ -258,9 +258,8 @@ void AccountSettings::slotCustomContextMenuRequested(const QPoint &pos)
         return;
     }
 
-
     // Only allow removal if the item isn't in "ready" state.
-    if (classification == FolderStatusModel::RootFolder && !_model->data(index, FolderStatusDelegate::IsReady).toBool() && !_model->folder(index)->isDeployed()) {
+    if (classification == FolderStatusModel::RootFolder && _model->folder(index)->isReady() && !_model->folder(index)->isDeployed()) {
         QMenu *menu = new QMenu(tv);
         menu->setAttribute(Qt::WA_DeleteOnClose);
         removeFolderAction(menu);

src/gui/folderstatusdelegate.h

@@ -48,8 +48,6 @@ class FolderStatusDelegate : public QStyledItemDelegate
 
         AddButton, // 1 = enabled; 2 = disabled
         FolderSyncText,
-        
-        IsReady // boolean
     };
     void paint(QPainter *, const QStyleOptionViewItem &, const QModelIndex &) const override;
     QSize sizeHint(const QStyleOptionViewItem &, const QModelIndex &) const override;

src/gui/folderstatusmodel.cpp

@@ -281,8 +281,6 @@ QVariant FolderStatusModel::data(const QModelIndex &index, int role) const
         return progress._overallSyncString;
     case FolderStatusDelegate::FolderSyncText:
         return tr("Local folder: %1").arg(f->shortGuiLocalPath());
-    case FolderStatusDelegate::IsReady:
-        return f->isReady();
     }
     return QVariant();
 }
@@ -570,9 +568,10 @@ bool FolderStatusModel::canFetchMore(const QModelIndex &parent) const
 
 void FolderStatusModel::fetchMore(const QModelIndex &parent)
 {
-    if (!data(parent, FolderStatusDelegate::IsReady).toBool()) {
+    if (!folder(parent)->isReady()) {
         return;
     }
+
     auto info = infoForIndex(parent);
 
     if (!info || info->_fetched || info->_fetchingJob)