test: add acceptance test for when the subadmin feature is disabled

Author: phil-davis

tests/acceptance/features/apiProvisioning-v1/createSubAdmin.feature

@@ -25,6 +25,15 @@ Feature: create a subadmin
     And the HTTP status code should be "200"
     And user "nonexistentuser" should not be a subadmin of group "brand-new-group"
 
+  @smokeTest
+  Scenario: admin tries to create a subadmin when the subadmin feature is disabled
+    Given user "brand-new-user" has been created with default attributes and without skeleton files
+    And group "brand-new-group" has been created
+    When the administrator tries to make user "brand-new-user" a subadmin of group "brand-new-group" using the provisioning API with the subadmin feature disabled
+    Then the OCS status code should be "103"
+    And the HTTP status code should be "200"
+    And user "brand-new-user" should not be a subadmin of group "brand-new-group"
+
 
   Scenario: admin tries to create a subadmin using a group which does not exist
     Given user "brand-new-user" has been created with default attributes and without skeleton files

tests/acceptance/features/bootstrap/Provisioning.php

@@ -4253,24 +4253,52 @@ public function adminMakesUserSubadminOfGroupUsingTheProvisioningApi(
 		);
 	}
 
+	/**
+	 * @When /^the administrator tries to make user "([^"]*)" a subadmin of group "([^"]*)" using the provisioning API with the subadmin feature disabled$/
+	 *
+	 * @param string $user
+	 * @param string $group
+	 *
+	 * @return void
+	 */
+	public function adminTriesToMakeUserSubadminOfGroupUsingTheProvisioningApiWithSubadminFeatureDisabled(
+		string $user,
+		string $group
+	):void {
+		$user = $this->getActualUsername($user);
+		$this->userMakesUserASubadminOfGroupUsingTheProvisioningApi(
+			$this->getAdminUsername(),
+			$user,
+			$group,
+			false
+		);
+	}
+
 	/**
 	 * @When user :user makes user :otherUser a subadmin of group :group using the provisioning API
 	 *
 	 * @param string $user
 	 * @param string $otherUser
 	 * @param string $group
+	 * @param bool $enableSubadminFeature
 	 *
 	 * @return void
 	 * @throws Exception
 	 */
 	public function userMakesUserASubadminOfGroupUsingTheProvisioningApi(
 		string $user,
 		string $otherUser,
-		string $group
+		string $group,
+		bool $enableSubadminFeature = true
 	):void {
-		// The subadmin feature is disabled by default; enable it so these
-		// scenarios can exercise it. Reverted in cleanupSubadminFeature().
-		$this->enableSubadminFeature();
+		if ($enableSubadminFeature) {
+			// The subadmin feature is disabled by default; enable it so these
+			// scenarios can exercise it. Reverted in cleanupSubadminFeature().
+			$this->enableSubadminFeature();
+		} else {
+			// Make sure that the Subadmin feature is disabled.
+			$this->cleanupSubadminFeature();
+		}
 		$actualUser = $this->getActualUsername($user);
 		$actualPassword = $this->getUserPassword($actualUser);
 		$actualSubadminUsername = $this->getActualUsername($otherUser);