Skip to content

Commit bfc61c0

Browse files
committed
test: use phan major version 6 code analysis
Now that PHP 7 support has been dropped, we can use the latest release of the phan code analyser. Patch releases before 6.0.7 had a problem with the function signatures for some Redis methods. That was corrected in phan/phan#5546 and released in phan version 6.0.7. So that version is required as the minimum here. #41650
1 parent 0d9c5e1 commit bfc61c0

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

changelog/unreleased/41650

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
Test: use phan major version 6 code analysis
2+
3+
Now that PHP 7 support has been dropped, we can use the latest release of the
4+
phan code analyser.
5+
6+
Patch releases before 6.0.7 had a problem with the function signatures for some
7+
Redis methods. That was corrected in https://github.com/phan/phan/pull/5546 and
8+
released in phan version 6.0.7. So that version is required as the minimum here.
9+
10+
https://github.com/owncloud/core/pull/41650

lib/private/User/DeletedUser.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
* This class is intended to be used internally.
3434
*/
3535
class DeletedUser implements IUser {
36-
/** @var Emitter */
37-
private $emitter;
36+
private Manager $emitter;
3837
/** @var IConfig */
3938
private $config;
4039
/** @var IURLGenerator */

vendor-bin/phan/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"require": {
3-
"phan/phan": "^5.5"
3+
"phan/phan": "^6.0.7"
44
}
55
}

0 commit comments

Comments
 (0)