federated shares do not work with filesnames > 63char

[individual-it]

Steps to reproduce

1. create a file called 123456789012345678901234567890123456789012345678901234567890.txt
2. share that file to a federated server

Expected behaviour

one of:

• sharing works correctly
• nice message shown that a shared file-name cannot have > 63 char

Actual behaviour

message shown:
Server error response [url] http://localhost/owncloud-core/ocs/v2.php/cloud/shares?format=json [status code] 500 [reason phrase] Internal Server Error

Server configuration

Operating system:
Ubuntu 18.04
Web server:
Apache2
Database:
MySQL
PHP version:
7.1
ownCloud version: (see ownCloud admin page)
10.0.10 RC4 (git)
Updated from an older ownCloud or fresh install:
fresh
Where did you install ownCloud from:
git

ownCloud log (data/owncloud.log)

{"reqId":"AtyF2aQFtNm1T7BatEll","level":3,"time":"2018-09-17T12:00:25+00:00","remoteAddr":"127.0.0.1","user":"--","app":"files_sharing","method":"POST","url":"\/owncloud-core\/ocs\/v2.php\/cloud\/shares?format=json","message":"server can not add remote share, An exception occurred while executing 'INSERT INTO `oc_share_external` (`remote`,`share_token`,`password`,`name`,`owner`,`user`,`mountpoint`,`mountpoint_hash`,`accepted`,`remote_id`) SELECT ?,?,?,?,?,?,?,?,?,? FROM `oc_share_external` WHERE `user` = ? AND `mountpoint_hash` = ? HAVING COUNT(*) = 0' with params [\"http:\\\/\\\/localhost\\\/owncloud-core\\\/\", \"d9O5FruD6NmqbIi\", \"\", \"\\\/123456789012345678901234567890123456789012345678901234567890.txt\", \"uu1\", \"admin\", \"{{TemporaryMountPointName#\\\/123456789012345678901234567890123456789012345678901234567890.txt}}\", \"5e1a7690067b7a69f2cfd1d6b1bd7c2e\", 0, 6, \"admin\", \"5e1a7690067b7a69f2cfd1d6b1bd7c2e\"]:\n\nSQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'name' at row 1"}
{"reqId":"7woFxaPCcCGGWd4PcyWV","level":3,"time":"2018-09-17T12:00:25+00:00","remoteAddr":"127.0.0.1","user":"uu1","app":"no app in context","method":"POST","url":"\/owncloud-core\/ocs\/v2.php\/apps\/files_sharing\/api\/v1\/shares?format=json","message":"Failed to notify remote server of federated share, removing share (Server error response [url] http:\/\/localhost\/owncloud-core\/ocs\/v2.php\/cloud\/shares?format=json [status code] 500 [reason phrase] Internal Server Error)"}

[ownclouders]

GitMate.io thinks the contributors most likely able to help are @PVince81, and @ownclouders.

Possibly related issues are #17952 (Sharing doesn't work), #19477 (Federated Cloud Sharing without Resharing), #22504 ([Federated Sharing] You can't edit the file), #22721 (Federated shares accepted and not displayed), and #16555 (Preview text icon does not work in federated shared files).

[individual-it]

GitMate.io thinks the contributors most likely able to help are @PVince81, and @ownclouders.

cool the bot thinks it can help, hope @ownclouders will soon start contributing bug fixes

[PVince81]

cc @VicDeo not sure why there would be a limit

[VicDeo]

@PVince81 https://github.com/owncloud/core/blob/master/apps/files_sharing/appinfo/Migrations/Version20170804201125.php#L47-L51

[PVince81]

ok, maybe we'll need to increase that to 250 which is also the size of the "name" column in oc_filecache.

[phil-davis]

Note: I also see a password column in that code that @VicDeo links to.
Is that used anywhere for a literal password, or is it always some hash value that fits in a 64-char string?

[VicDeo]

@phil-davis not a user password but a public share password (token)

[phil-davis]

As long as it is a generated token that is never longer than 64 chars, then that password field is fine :)