No notification when server email not set

[cortho]

When, for whatever reason, the server email is not set (Admin Settings -> General -> Email server) or invalid, adding guests is possible, but the email will never be sent. Not even an error message is displayed.

I'm not sure, which is the best place to display this (maybe a notification?).
Sharing with guests should not be possible, unless this email address is valid.
We should add this to the README too?

[davitol]

@pmaier1 FYI

[cortho]

I'm ready to implement this in the guests app scope. There are only the questions where to put and who can see this

• visibility:
  show for admin only or for every user (for the latter something like 'server email not set, contact your admin'). IMHO a user should know, when it is not possible to invite a guest.
• where to show
  • as yellow notification on the top
  • as red paragraph in admin guests settings
• wording?

@pmaier1 your recommendation?

[pmaier1]

show for admin only or for every user (for the latter something like 'server email not set, contact your admin'). IMHO a user should know, when it is not possible to invite a guest.

Two possibilities IMHO:

1. Only admin can see the warning. In this case I would place it in the security and setup warnings at the top of admin general settings and additionally disable the functionality of the guests app until this is resolved (users won't run into issues accidentially).
2. Users can see the warning. In this case I would show the warning in the guest share creation modal to indicate that it won't work and to direct users to their admin.

I'm in favor of 1) with the following wording:

"Guests app functionality is temporarily disabled. To use the guests app it is necessary to have a properly configured mail server in ownCloud. Please find instructions on how to configure ownCloud to be able to send mails here."

Another option would be not allowing to enable the guests app when there's no mail server configured. Maybe this is the most feasible solution. An error message like above would be needed as well, of course.

What do you think?

[cortho]

I'm in favor of 1) [disable the functionality] with the following wording

👍 This is even better. The admin has to take care of the setup.

I don't like the other option so much, because it is possible, that the server email address vanishes after having the app enabled

[pmaier1]

I don't like the other option so much, because it is possible, that the server email address vanishes after having the app enabled

Good point!

This is even better. The admin has to take care of the setup.

Looks like we have an agreement :) 👍