Skip to content

Commit 1b886a7

Browse files
committed
added issues in expected failure file
Signed-off-by: nabim777 <[email protected]>
1 parent 62e9a41 commit 1b886a7

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

tests/acceptance/bootstrap/SpacesTUSContext.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -185,11 +185,7 @@ private function uploadFileViaTus(
185185
string $resource,
186186
string $spaceName
187187
): ResponseInterface {
188-
if ($spaceName === 'Shares') {
189-
$spaceId = GraphHelper::SHARES_SPACE_ID;
190-
} else {
191-
$spaceId = $this->spacesContext->getSpaceIdByName($user, $spaceName);
192-
}
188+
$spaceId = $this->spacesContext->getSpaceIdByName($user, $spaceName);
193189
$tmpFile = $this->tusContext->writeDataToTempFile($content);
194190
$response = $this->tusContext->uploadFileUsingTus(
195191
$user,
@@ -252,8 +248,7 @@ public function userUploadsAFileWithContentToViaTusInsideOfTheSpaceUsingTheWebda
252248
): void {
253249
$isSpacesDavPathVersion = $this->featureContext->getDavPathVersion() === WebDavHelper::DAV_VERSION_SPACES;
254250
if (!$isSpacesDavPathVersion) {
255-
$resource = \ltrim($resource, "/");
256-
$resource = 'Shares/' . $resource;
251+
$resource = 'Shares/' . \ltrim($resource, "/");
257252
}
258253
$this->featureContext->setResponse($this->uploadFileViaTus($user, $content, $resource, $spaceName));
259254
}

tests/acceptance/expected-failures-without-remotephp.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,10 +353,14 @@
353353
- [coreApiWebdavUploadTUS/uploadFileMtimeShares.feature:72](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadFileMtimeShares.feature#L72)
354354
- [coreApiWebdavUploadTUS/uploadFileMtimeShares.feature:93](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadFileMtimeShares.feature#L93)
355355
- [coreApiWebdavUploadTUS/uploadToMoveFolder.feature:21](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToMoveFolder.feature#L21)
356+
- [coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature:19](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature#L19)
357+
- [coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature:36](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature#L36)
358+
- [coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature:62](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature#L62)
356359
- [coreApiWebdavUploadTUS/uploadToShare.feature:30](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L30)
357360
- [coreApiWebdavUploadTUS/uploadToShare.feature:51](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L51)
358361
- [coreApiWebdavUploadTUS/uploadToShare.feature:74](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L74)
359362
- [coreApiWebdavUploadTUS/uploadToShare.feature:96](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L96)
363+
- [coreApiWebdavUploadTUS/uploadToShare.feature:116](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L116)
360364

361365
#### [PROPFIND to /webdav root (old dav path) without remote.php returns html instead of xml](https://github.com/owncloud/ocis/issues/10334)
362366

tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Feature: upload file
77
Given using OCS API version "1"
88
And user "Alice" has been created with default attributes
99

10-
10+
@issue-10346
1111
Scenario Outline: attempt to upload a file into a nonexistent shares
1212
Given using <dav-path-version> DAV path
1313
When user "Alice" uploads a file with content "uploaded content" to "/Shares/FOLDER/textfile.txt" via TUS inside of the space "Personal" using the WebDAV API
@@ -24,7 +24,7 @@ Feature: upload file
2424
| dav-path-version |
2525
| spaces |
2626

27-
27+
@issue-10346
2828
Scenario Outline: attempt to upload a file into a nonexistent folder
2929
Given using <dav-path-version> DAV path
3030
When user "Alice" uploads a file with content "uploaded content" to "/nonExistentFolder/textfile.txt" via TUS inside of the space "Personal" using the WebDAV API
@@ -41,7 +41,7 @@ Feature: upload file
4141
| dav-path-version |
4242
| spaces |
4343

44-
@skipOnReva
44+
@skipOnReva @issue-10346
4545
Scenario Outline: attempt to upload a file into a nonexistent folder within correctly received share
4646
Given using <dav-path-version> DAV path
4747
And user "Brian" has been created with default attributes

tests/acceptance/tus-upload-test-ZjY6Hf

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)