fix: list shares, avoid 5xx on any share already shared

Author: mklos-kw

changelog/unreleased/fix-error-on-listing-space-members.md

@@ -0,0 +1,6 @@
+Bugfix: Fix error on listing space members
+
+Now the members list will still show grantees even with there is any invalid share after the upgrade.
+
+https://github.com/owncloud/ocis/pull/11245
+https://github.com/owncloud/ocis/issues/11119

services/graph/pkg/service/v0/api_driveitem_permissions.go

@@ -6,6 +6,7 @@ import (
 	"net/http"
 	"net/url"
 	"slices"
+	"strings"
 
 	gateway "github.com/cs3org/go-cs3apis/cs3/gateway/v1beta1"
 	grouppb "github.com/cs3org/go-cs3apis/cs3/identity/group/v1beta1"
@@ -22,6 +23,7 @@ import (
 	"go.opentelemetry.io/otel/trace"
 
 	revactx "github.com/owncloud/reva/v2/pkg/ctx"
+	"github.com/owncloud/reva/v2/pkg/errtypes"
 	"github.com/owncloud/reva/v2/pkg/publicshare"
 	"github.com/owncloud/reva/v2/pkg/rgrpc/todo/pool"
 	"github.com/owncloud/reva/v2/pkg/share"
@@ -462,8 +464,8 @@ func (s DriveItemPermissionsService) ListPermissions(ctx context.Context, itemID
 	driveItems, err = s.listPublicShares(ctx, []*link.ListPublicSharesRequest_Filter{
 		publicshare.ResourceIDFilter(itemID),
 	}, driveItems)
-	if err != nil {
-		s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("listPublicShares failed")
+	s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("listPublicShares failed")
+	if err != nil && !strings.Contains(err.Error(), errtypes.ERR_ALREADY_EXISTS) {
 		return collectionOfPermissions, err
 	}