Skip to content

Commit 2e86d35

Browse files
mklos-kw2403905claude
authored
fix: CI, release pipeline fixes from 8.2-rc.1 (#12561)
* fix(ci): disable docker release jobs like in 8.1 The docker-build/manifest/readme jobs were enabled in 8.2 and wired into create-github-release/audit-release. They fail at docker/login-action ("Username and password required") because DockerHub credentials are not available, which cascades and cancels the whole release. Restore the 8.1 behavior: re-add `if: false` to the docker jobs and unwire them from the downstream release jobs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(ci): reinstall web deps in license-check job Excluding web from the generated-code artifact (#12557, to avoid OOM on upload) also dropped web/node_modules, which provides the license-checker-rseidelsohn binary used by `make ci-node-check-licenses`. The job failed with "license-checker-rseidelsohn: not found". Run `pnpm install` in web before the license check so its node_modules is present again. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Roman Perekhod <2403905@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 084c971 commit 2e86d35

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ jobs:
113113
retention-days: 1
114114

115115
docker-build:
116+
if: false
116117
name: docker-build (${{ matrix.arch }}, ${{ matrix.repo }})
117118
runs-on: ${{ matrix.arch == 'amd64' && 'ubuntu-24.04' || 'ubuntu-24.04-arm' }}
118119
needs: [determine-release-type, generate-code, security-scan-trivy]
@@ -218,6 +219,7 @@ jobs:
218219
exit 1
219220
220221
docker-manifest:
222+
if: false
221223
name: docker-manifest (${{ matrix.repo }})
222224
runs-on: ubuntu-latest
223225
needs: [determine-release-type, docker-build, docker-scan]
@@ -243,6 +245,7 @@ jobs:
243245
"${{ matrix.repo }}:${{ needs.determine-release-type.outputs.version }}-linux-arm64"
244246
245247
docker-readme:
248+
if: false
246249
name: docker-readme (${{ matrix.repo }})
247250
runs-on: ubuntu-latest
248251
needs: [determine-release-type, docker-manifest]
@@ -314,6 +317,10 @@ jobs:
314317
with:
315318
go-version-file: go.mod
316319
- run: npm install --silent -g yarn npx "pnpm@$PNPM_VERSION" --force
320+
# web is excluded from the generated-code artifact (see generate-code) to
321+
# avoid OOM on upload, so its node_modules — which provides the
322+
# license-checker-rseidelsohn binary — must be reinstalled here.
323+
- run: cd web && pnpm install
317324
- run: make ci-node-check-licenses && make ci-node-save-licenses
318325
- run: make ci-go-check-licenses && make ci-go-save-licenses
319326
- run: tar -czf third-party-licenses.tar.gz -C third-party-licenses .
@@ -348,7 +355,7 @@ jobs:
348355

349356
create-github-release:
350357
runs-on: ubuntu-latest
351-
needs: [determine-release-type, build-binaries, license-check, generate-changelog, security-scan-trivy, docker-readme]
358+
needs: [determine-release-type, build-binaries, license-check, generate-changelog, security-scan-trivy]
352359
steps:
353360
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
354361
with:
@@ -379,10 +386,6 @@ jobs:
379386
needs:
380387
- determine-release-type
381388
- generate-code
382-
- docker-build
383-
- docker-scan
384-
- docker-manifest
385-
- docker-readme
386389
- build-binaries
387390
- security-scan-trivy
388391
- license-check
@@ -406,7 +409,7 @@ jobs:
406409
python3 scripts/audit-release.py \
407410
--version "${{ needs.determine-release-type.outputs.version }}" \
408411
--dir release-assets/ \
409-
--github-release --docker
412+
--github-release
410413
env:
411414
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
412415

0 commit comments

Comments
 (0)