fix retry for notification

Author: amrita-shrestha

tests/acceptance/bootstrap/NotificationContext.php

@@ -329,20 +329,18 @@ public function filterResponseAccordingToNotificationSubject(
 		?ResponseInterface $response = null
 	): object {
 		$response = $response ?? $this->featureContext->getResponse();
+
 		if (isset($this->featureContext->getJsonDecodedResponseBodyContent($response)->ocs->data)) {
 			$responseBody = $this->featureContext->getJsonDecodedResponseBodyContent($response)->ocs->data;
 			foreach ($responseBody as $value) {
 				if (isset($value->subject) && $value->subject === $subject) {
-					$responseBody = $value;
 					// set notificationId
 					$this->notificationIds[] = $value->notification_id;
-					break;
+					return $value;
 				}
 			}
-		} else {
-			$responseBody = $this->featureContext->getJsonDecodedResponseBodyContent($response);
 		}
-		return $responseBody;
+		return (object) [];
 	}
 
 	/**

tests/acceptance/features/apiNotification/notification.feature

@@ -8,7 +8,6 @@ Feature: Notification
       | username |
       | Alice    |
       | Brian    |
-      | Carol    |
     And user "Alice" has uploaded file with content "other data" to "/textfile1.txt"
     And user "Alice" has created folder "my_data"
 

tests/acceptance/features/apiNotification/shareExpireNotification.feature

@@ -0,0 +1,30 @@
+@email
+Feature: Share Expiry Notification
+  As a user
+  I want to be notified when share expires
+  So that I can stay updated about the share
+
+  Background:
+    Given these users have been created with default attributes:
+      | username |
+      | Alice    |
+      | Brian    |
+
+
+  Scenario: check share expired in-app and mail notification for Personal space resource
+    Given user "Alice" has uploaded file with content "hello world" to "testfile.txt"
+    And user "Alice" has sent the following resource share invitation:
+      | resource           | testfile.txt         |
+      | space              | Personal             |
+      | sharee             | Brian                |
+      | shareType          | user                 |
+      | permissionsRole    | Viewer               |
+      | expirationDateTime | 2025-07-15T14:00:00Z |
+    When user "Alice" expires the last created share:
+      | space    | Personal     |
+      | resource | testfile.txt |
+    Then the HTTP status code should be "200"
+    And user "Brian" should get a notification with subject "Membership expired" and message:
+      | message                           |
+      | Access to Space Alice Hansen lost |
+    And user "Brian" should have "2" emails

tests/acceptance/features/apiSettings/notificationSetting.feature

@@ -758,24 +758,3 @@ Feature: Notification Settings
     Then the HTTP status code should be "200"
     And the notifications should be empty
     And user "Brian" should have "0" emails
-
-
-  Scenario: check share expired in-app and mail notification for Personal space resource
-    Given user "Alice" has uploaded file with content "hello world" to "testfile.txt"
-    And user "Alice" has sent the following resource share invitation:
-      | resource           | testfile.txt         |
-      | space              | Personal             |
-      | sharee             | Brian                |
-      | shareType          | user                 |
-      | permissionsRole    | Viewer               |
-      | expirationDateTime | 2025-07-15T14:00:00Z |
-    When user "Alice" expires the last created share:
-      | space    | Personal     |
-      | resource | testfile.txt |
-    Then the HTTP status code should be "200"
-    And for user "Brian" the space "Shares" should not contain these entries:
-      | testfile.txt |
-    And user "Brian" should get a notification with subject "Membership expired" and message:
-      | message                           |
-      | Access to Space Alice Hansen lost |
-    And user "Brian" should have "2" emails