Merge pull request #11530 from owncloud/test/delete-notification-by-id

[tests-only][full-ci] Add test to delete a notification using its id

Author: anon-pradip

tests/acceptance/bootstrap/NotificationContext.php

@@ -24,7 +24,7 @@
  */
 class NotificationContext implements Context {
 	private FeatureContext $featureContext;
-	private string $notificationEndpointPath = '/apps/notifications/api/v1/notifications?format=json';
+	private string $notificationEndpointPath = '/apps/notifications/api/v1/notifications';
 	private string $globalNotificationEndpointPath = '/apps/notifications/api/v1/notifications/global';
 
 	private array $notificationIds;
@@ -115,7 +115,7 @@ public function listAllNotifications(string $user): ResponseInterface {
 			$this->featureContext->getActualUsername($user),
 			$this->featureContext->getPasswordForUser($user),
 			'GET',
-			$this->notificationEndpointPath,
+			$this->notificationEndpointPath . '?format=json',
 			[],
 			2,
 			$headers,
@@ -216,7 +216,7 @@ public function userDeletesNotification(string $user): ResponseInterface {
 			$this->featureContext->getActualUsername($user),
 			$this->featureContext->getPasswordForUser($user),
 			'DELETE',
-			$this->notificationEndpointPath,
+			$this->notificationEndpointPath . '?format=json',
 			\json_encode($payload),
 			2,
 		);
@@ -614,4 +614,50 @@ public function userDeletesDeprovisioningNotification(?string $user = null): voi
 		);
 		$this->featureContext->setResponse($response);
 	}
+
+	/**
+	 * deletes notification using id
+	 *
+	 * @param string $user
+	 * @param string $notificationId
+	 *
+	 * @return ResponseInterface
+	 * @throws GuzzleException
+	 * @throws JsonException
+	 */
+	public function deleteNotificationUsingId(string $user, string $notificationId): ResponseInterface {
+		$deleteNotificationEndpoint = $this->notificationEndpointPath . '/' . $notificationId;
+		return OcsApiHelper::sendRequest(
+			$this->featureContext->getBaseUrl(),
+			$this->featureContext->getActualUsername($user),
+			$this->featureContext->getPasswordForUser($user),
+			'DELETE',
+			$deleteNotificationEndpoint,
+		);
+	}
+
+	/**
+	 * @When user :user deletes a notification related to resource :resource with subject :subject using id
+	 *
+	 * @param string $user
+	 * @param string $resource
+	 * @param string $subject
+	 *
+	 * @return void
+	 * @throws GuzzleException
+	 * @throws JsonException
+	 */
+	public function userDeletesNotificationOfResourceAndSubjectById(
+		string $user,
+		string $resource,
+		string $subject,
+	): void {
+		$allNotifications = $this->listAllNotifications($user);
+		$filteredNotificationId = $this->filterNotificationsBySubjectAndResource(
+			$subject,
+			$resource,
+			$allNotifications,
+		)[0]->notification_id;
+		$this->featureContext->setResponse($this->deleteNotificationUsingId($user, $filteredNotificationId));
+	}
 }

tests/acceptance/features/apiNotification/deleteNotification.feature

@@ -38,3 +38,12 @@ Feature: Delete notification
     When user "Brian" deletes all notifications
     Then the HTTP status code should be "200"
     And user "Brian" should not have any notification
+
+
+  Scenario: delete a notification using id
+    When user "Brian" deletes a notification related to resource "my_data" with subject "Resource shared" using id
+    Then the HTTP status code should be "200"
+    And user "Brian" should have a notification with subject "Resource shared" and message:
+      | message                                    |
+      | Alice Hansen shared textfile1.txt with you |
+    But user "Brian" should not have a notification related to resource "my_data" with subject "Resource shared"