fix: error handling

jvillafanez · jvillafanez · commit 5917fdf62478 · 2025-05-15T15:53:43.000+02:00
diff --git a/services/search/pkg/engine/bleve/index.go b/services/search/pkg/engine/bleve/index.go
@@ -106,7 +106,7 @@ func (i *IndexGetterPersistent) GetIndex(opts ...GetIndexOption) (bleve.Index, f
 	}
 
 	i.index = index
-	return i.index, closeFn, nil
+	return i.index, closeFn, err
 }
 
 // IndexGetterPersistentScale is an implementation of IndexGetter that persists
@@ -149,8 +149,6 @@ func (i *IndexGetterPersistentScale) GetIndex(opts ...GetIndexOption) (bleve.Ind
 			closeFn := func() {} // no-op
 			return nil, closeFn, err
 		}
-
-		return index, func() { index.Close() }, nil
 	}
 
 	return index, func() { index.Close() }, err

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ func (i *IndexGetterPersistent) GetIndex(opts ...GetIndexOption) (bleve.Index, f`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`i.index = index`
`109`		`- return i.index, closeFn, nil`
	`109`	`+ return i.index, closeFn, err`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`// IndexGetterPersistentScale is an implementation of IndexGetter that persists`
`@@ -149,8 +149,6 @@ func (i *IndexGetterPersistentScale) GetIndex(opts ...GetIndexOption) (bleve.Ind`
`149`	`149`	`closeFn := func() {} // no-op`
`150`	`150`	`return nil, closeFn, err`
`151`	`151`	`}`
`152`		`-`
`153`		`- return index, func() { index.Close() }, nil`
`154`	`152`	`}`
`155`	`153`
`156`	`154`	`return index, func() { index.Close() }, err`