Merge pull request #11543 from 2403905/issues/OCISDEV-209

fix: [OCISDEV-209] fix graph create link endpoint

Author: 2403905

changelog/unreleased/fix-create-link.md

@@ -0,0 +1,6 @@
+Bugfix: Fix the create link endpoint
+
+We fixed an issue when Shares drive can be shared via link share with Internal role using permissions endpoint 
+
+https://github.com/owncloud/ocis/pull/11542  
+https://github.com/owncloud/ocis/issues/11409

services/graph/pkg/service/v0/api_driveitem_permissions_links.go

@@ -153,12 +153,18 @@ func (api DriveItemPermissionsApi) CreateLink(w http.ResponseWriter, r *http.Req
 	logger := api.logger.SubloggerWithRequestID(r.Context())
 	logger.Info().Msg("calling create link")
 
-	_, driveItemID, err := GetDriveAndItemIDParam(r, &logger)
+	driveID, driveItemID, err := GetDriveAndItemIDParam(r, &logger)
 	if err != nil {
 		errorcode.RenderError(w, r, err)
 		return
 	}
 
+	if IsShareJail(driveID) && driveID.GetSpaceId() == driveItemID.GetOpaqueId() {
+		api.logger.Debug().Interface("driveItemID", driveItemID).Msg("cannot create link on shares space root")
+		errorcode.InvalidRequest.Render(w, r, http.StatusBadRequest, "cannot create link on shares space root")
+		return
+	}
+
 	var createLink libregraph.DriveItemCreateLink
 	if err = StrictJSONUnmarshal(r.Body, &createLink); err != nil {
 		logger.Error().Err(err).Interface("body", r.Body).Msg("could not create link: invalid body schema definition")

tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md

@@ -377,10 +377,6 @@ The expected failures in this file are from features in the owncloud/ocis repo.
 
 - [apiSpacesShares/moveSpaces.feature:377](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/moveSpaces.feature#L377)
 
-#### [Shares drive can be shared via link share with Internal role using permissions endpoint](https://github.com/owncloud/ocis/issues/11409)
-
-- [apiSharingNgDriveLinkShare/createInternalLinkShare.feature:339](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSharingNgDriveLinkShare/createInternalLinkShare.feature#L339)
-
 #### [Activities. no event for restoring file](https://github.com/owncloud/ocis/issues/10010)
 
 - [apiActivities/activities.feature:3772](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiActivities/activities.feature#L3772)

tests/acceptance/features/apiSharingNgDriveLinkShare/createDriveLinkShare.feature

@@ -232,11 +232,11 @@ Feature: Link sharing of project spaces
       """
     Examples:
       | permissions-role | drive    | message                                   |
-      | View             | Shares   | no share permission                       |
-      | Edit             | Shares   | no share permission                       |
-      | Upload           | Shares   | no share permission                       |
-      | File Drop        | Shares   | no share permission                       |
-      | Secure View      | Shares   | invalid link type                         |
+      | View             | Shares   | cannot create link on shares space root   |
+      | Edit             | Shares   | cannot create link on shares space root   |
+      | Upload           | Shares   | cannot create link on shares space root   |
+      | File Drop        | Shares   | cannot create link on shares space root   |
+      | Secure View      | Shares   | cannot create link on shares space root   |
       | View             | Personal | cannot create link on personal space root |
       | Edit             | Personal | cannot create link on personal space root |
       | Upload           | Personal | cannot create link on personal space root |

tests/acceptance/features/apiSharingNgDriveLinkShare/createInternalLinkShare.feature

@@ -360,16 +360,16 @@ Feature: Internal link share of project spaces
                 "type": "object",
                 "required": ["date","request-id"]
               },
-              "message": {"const": "password is redundant for the internal link"}
+              "message": {"const": "<message>"}
             }
           }
         }
       }
       """
     Examples:
-      | drive    |
-      | Personal |
-      | Shares   |
+      | drive    | message                                     |
+      | Personal | password is redundant for the internal link |
+      | Shares   | cannot create link on shares space root     |
 
 
   Scenario: create an internal quick link share of a project-space using permissions endpoint