fix: list shares 5xx on already shared

mklos-kw · mklos-kw · commit 9c73b2aa659f · 2025-04-23T08:22:14.000+02:00
diff --git a/services/graph/pkg/service/v0/api_driveitem_permissions.go b/services/graph/pkg/service/v0/api_driveitem_permissions.go
@@ -462,8 +462,8 @@ func (s DriveItemPermissionsService) ListPermissions(ctx context.Context, itemID
 	driveItems, err = s.listPublicShares(ctx, []*link.ListPublicSharesRequest_Filter{
 		publicshare.ResourceIDFilter(itemID),
 	}, driveItems)
-	if err != nil {
 		s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("listPublicShares failed")
+	if err != nil && !strings.Contains(err.Error(), errtypes.ERR_ALREADY_EXISTS) {
 		return collectionOfPermissions, err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -462,8 +462,8 @@ func (s DriveItemPermissionsService) ListPermissions(ctx context.Context, itemID`
`462`	`462`	`driveItems, err = s.listPublicShares(ctx, []*link.ListPublicSharesRequest_Filter{`
`463`	`463`	`publicshare.ResourceIDFilter(itemID),`
`464`	`464`	`}, driveItems)`
`465`		`- if err != nil {`
`466`	`465`	`s.logger.Error().Err(err).Str("storageID", itemID.GetStorageId()).Msg("listPublicShares failed")`
	`466`	`+ if err != nil && !strings.Contains(err.Error(), errtypes.ERR_ALREADY_EXISTS) {`
`467`	`467`	`return collectionOfPermissions, err`
`468`	`468`	`}`
`469`	`469`