added issues in expected failure file

Signed-off-by: nabim777 <[email protected]>

Author: nabim777

tests/acceptance/bootstrap/SpacesTUSContext.php

@@ -185,11 +185,7 @@ private function uploadFileViaTus(
 		string $resource,
 		string $spaceName
 	): ResponseInterface {
-		if ($spaceName === 'Shares') {
-			$spaceId = GraphHelper::SHARES_SPACE_ID;
-		} else {
-			$spaceId = $this->spacesContext->getSpaceIdByName($user, $spaceName);
-		}
+		$spaceId = $this->spacesContext->getSpaceIdByName($user, $spaceName);
 		$tmpFile = $this->tusContext->writeDataToTempFile($content);
 		$response = $this->tusContext->uploadFileUsingTus(
 			$user,
@@ -251,9 +247,11 @@ public function userUploadsAFileWithContentToViaTusInsideOfTheSpaceUsingTheWebda
 		string $spaceName
 	): void {
 		$isSpacesDavPathVersion = $this->featureContext->getDavPathVersion() === WebDavHelper::DAV_VERSION_SPACES;
-		if (!$isSpacesDavPathVersion) {
-			$resource = \ltrim($resource, "/");
+		$resource = \ltrim($resource, "/");
+		if (!$isSpacesDavPathVersion && $spaceName === 'Shares' && !\str_starts_with($resource, "Shares/")) {
 			$resource = 'Shares/' . $resource;
+		} elseif ($isSpacesDavPathVersion && \str_starts_with($resource, "Shares/")) {
+			$resource = \preg_replace("/^Shares\//", "", $resource);
 		}
 		$this->featureContext->setResponse($this->uploadFileViaTus($user, $content, $resource, $spaceName));
 	}

tests/acceptance/bootstrap/TUSContext.php

@@ -519,7 +519,7 @@ public function userHasUploadedFileWithMtimeUsingTUS(
 		$this->featureContext->setLastUploadDeleteTime(\time());
 		$this->featureContext->theHTTPStatusCodeShouldBe(
 			["201", "204"],
-			"HTTP status code was not 201 or 204 while trying to upload file '$source' for user '$user'",
+			"Failed to upload file '$source' for user '$user'",
 			$response
 		);
 	}

tests/acceptance/expected-failures-without-remotephp.md

@@ -353,10 +353,14 @@
 - [coreApiWebdavUploadTUS/uploadFileMtimeShares.feature:72](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadFileMtimeShares.feature#L72)
 - [coreApiWebdavUploadTUS/uploadFileMtimeShares.feature:93](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadFileMtimeShares.feature#L93)
 - [coreApiWebdavUploadTUS/uploadToMoveFolder.feature:21](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToMoveFolder.feature#L21)
+- [coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature:19](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature#L19)
+- [coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature:36](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature#L36)
+- [coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature:62](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature#L62)
 - [coreApiWebdavUploadTUS/uploadToShare.feature:30](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L30)
 - [coreApiWebdavUploadTUS/uploadToShare.feature:51](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L51)
 - [coreApiWebdavUploadTUS/uploadToShare.feature:74](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L74)
 - [coreApiWebdavUploadTUS/uploadToShare.feature:96](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L96)
+- [coreApiWebdavUploadTUS/uploadToShare.feature:116](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUploadTUS/uploadToShare.feature#L116)
 
 #### [PROPFIND to /webdav root (old dav path) without remote.php returns html instead of xml](https://github.com/owncloud/ocis/issues/10334)
 

tests/acceptance/features/coreApiWebdavUploadTUS/uploadToNonExistingFolder.feature

@@ -7,7 +7,7 @@ Feature: upload file
     Given using OCS API version "1"
     And user "Alice" has been created with default attributes
 
-
+  @issue-10346
   Scenario Outline: attempt to upload a file into a nonexistent shares
     Given using <dav-path-version> DAV path
     When user "Alice" uploads a file with content "uploaded content" to "/Shares/FOLDER/textfile.txt" via TUS inside of the space "Personal" using the WebDAV API
@@ -24,7 +24,7 @@ Feature: upload file
       | dav-path-version |
       | spaces           |
 
-
+  @issue-10346
   Scenario Outline: attempt to upload a file into a nonexistent folder
     Given using <dav-path-version> DAV path
     When user "Alice" uploads a file with content "uploaded content" to "/nonExistentFolder/textfile.txt" via TUS inside of the space "Personal" using the WebDAV API
@@ -41,7 +41,7 @@ Feature: upload file
       | dav-path-version |
       | spaces           |
 
-  @skipOnReva
+  @skipOnReva @issue-10346
   Scenario Outline: attempt to upload a file into a nonexistent folder within correctly received share
     Given using <dav-path-version> DAV path
     And user "Brian" has been created with default attributes