dbg: e2e tests

Author: mklos-kw

services/proxy/pkg/middleware/signed_url_auth.go

@@ -144,6 +144,14 @@ func (m SignedURLAuthenticator) urlIsExpired(query url.Values) (err error) {
 }
 
 func (m SignedURLAuthenticator) signatureIsValid(req *http.Request) (err error) {
+	start := time.Now()
+	defer func() {
+		m.Logger.Debug().
+			Str("duration", time.Since(start).String()).
+			Str("path", req.URL.Path).
+			Msg("signature validation completed")
+	}()
+
 	c := revactx.ContextMustGetUser(req.Context())
 	signingKey, err := m.Store.Read(c.Id.OpaqueId)
 	if err != nil {
@@ -205,6 +213,14 @@ func (m SignedURLAuthenticator) buildUrlToSign(req *http.Request) string {
 }
 
 func (m SignedURLAuthenticator) createSignature(url string, signingKey []byte) string {
+	start := time.Now()
+	defer func() {
+		m.Logger.Debug().
+			Str("duration", time.Since(start).String()).
+			Str("url", url).
+			Msg("signature creation completed")
+	}()
+
 	// the oc10 signature check: $hash = \hash_pbkdf2("sha512", $url, $signingKey, 10000, 64, false);
 	// - sets the length of the output string to 64
 	// - sets raw output to false ->  if raw_output is FALSE length corresponds to twice the byte-length of the derived key (as every byte of the key is returned as two hexits).

services/proxy/pkg/middleware/signed_url_auth_test.go

@@ -158,6 +158,49 @@ func TestSignedURLAuth_createSignature(t *testing.T) {
 	}
 }
 
+func TestSignedURLAuth_createSignature_executionTime(t *testing.T) {
+	// Setup test environment
+	pua := &SignedURLAuthenticator{
+		PreSignedURLConfig: config.PreSignedURL{
+			Enabled: true,
+		},
+	}
+
+	// Create test data
+	baseURL := "https://example.com/"
+	signingKey := []byte("somerandomkey")
+
+	// Generate random string of length 128
+	generateRandomString := func(length int) string {
+		const charset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
+		b := make([]byte, length)
+		for i := range b {
+			b[i] = charset[i%len(charset)]
+		}
+		return string(b)
+	}
+
+	N := 100
+	// Pre-generate random strings to avoid measuring string generation time
+	randomStrings := make([]string, N)
+	for i := 0; i < N; i++ {
+		randomStrings[i] = generateRandomString(128)
+	}
+	start := time.Now()
+	for i := 0; i < N; i++ {
+		// Simulate download verification
+		signature := pua.createSignature(baseURL+randomStrings[i], signingKey)
+		if signature == "" {
+			t.Fatal("signature creation failed")
+		}
+	}
+	took := time.Since(start)
+	avg := took.Milliseconds() / int64(N)
+	// Key iterations: 10000, ~2 ms local, ~5ms CI
+	// Key iterations: 256*1024, ~73 ms local, ~154ms CI
+	assert.Less(t, avg, int64(100))
+}
+
 func TestSignedURLAuth_validate(t *testing.T) {
 	nowFunc := func() time.Time {
 		t, _ := time.Parse(time.RFC3339, "2020-02-02T12:30:00.000Z")

services/webdav/pkg/service/v0/service.go

@@ -467,6 +467,11 @@ func (g Webdav) PublicThumbnailHead(w http.ResponseWriter, r *http.Request) {
 
 func (g Webdav) sendThumbnailResponse(rsp *thumbnailssvc.GetThumbnailResponse, w http.ResponseWriter, r *http.Request) {
 	logger := g.log.SubloggerWithRequestID(r.Context())
+	logger.Debug().
+		Str("endpoint", rsp.DataEndpoint).
+		Str("transfer_token", rsp.TransferToken).
+		Msg("initiating download request")
+
 	client := &http.Client{
 		// Timeout: time.Second * 5,
 	}