feat: handle missing node id in tus

Author: LarsJurgensen

internal/http/services/owncloud/ocdav/tus.go

@@ -319,7 +319,8 @@ func (s *svc) handleTusPost(ctx context.Context, w http.ResponseWriter, r *http.
 				sReq.Ref.Path = uReq.Ref.GetPath()
 				sReq.Ref.ResourceId = nil
 			} else {
-				if resid, err := storagespace.ParseID(httpRes.Header.Get(net.HeaderOCFileID)); err == nil {
+				// new files have no node id yet; keep the path-based ref instead
+			if resid, err := storagespace.ParseID(httpRes.Header.Get(net.HeaderOCFileID)); err == nil && resid.GetOpaqueId() != "" {
 					sReq.Ref = &provider.Reference{
 						ResourceId: &resid,
 					}

pkg/rhttp/datatx/manager/tus/tus.go

@@ -212,6 +212,10 @@ func setHeaders(coord upload.Coordinator, w http.ResponseWriter, r *http.Request
 	if expires != "" {
 		w.Header().Set(net.HeaderTusUploadExpires, expires)
 	}
+	// the node id is only valid once the upload commits; skip the header for new files
+	if info.Storage["NodeExists"] != "true" {
+		return
+	}
 	resourceid := &provider.ResourceId{
 		StorageId: info.MetaData["providerID"],
 		SpaceId:   info.Storage["SpaceRoot"],