test: add a javascript unit test harness for the classic frontend [4.2] (#630)

Backport of #623. js/documents.js is byte-identical between this branch and
master, so it carries the same navigation and post message guards as the
master-side fix and had exactly the same problem: no automated coverage, and
no JavaScript job in CI.

Makefile and both files under tests/js/ are byte-identical to master's.
package.json and pnpm-lock.yaml are master's karma additions applied to this
branch's tree rather than copies of it, because the two trees have since
diverged: #629 bumped vue to 3.5.42 here while master is still on 3.5.40, and
#632 moved the pnpm settings into pnpm-workspace.yaml here while master's still
sit in package.json. The lockfile delta is 938 insertions and 3 deletions, the
same as the master-side change, and adds nothing but the karma tree - no package
is removed and no version moves.

The CI job is the one part that needed adapting. js-unit.yml has no
core-ref-php74 input and no case() on the php version, unlike php-codestyle.yml
and php-unit.yml above it, so the core checkout is selected by core-ref alone -
10.16 here, since an app declaring max-version="10" cannot be enabled on a
master core.

This is also the first job on this branch to install node dependencies, which is
what made the broken lockfile #632 repaired invisible here until now.

Verified against a real 10.16 core: 37 of 37 specs pass, and they still fail
with the expected wrong values when the scheme guard in _absoluteHttpUrl is
defeated. core/js/core.json is byte-identical between core master and 10.16 and
core 10.16 ships the same core/vendor symlink from its build postinstall, so the
karma config needed no path changes. core 10.16's specHelper.js lacks the
jasmine.pp shim master's carries for jasmine-sinon, which turns out not to
matter here: jasmine-sinon delegates to jasmine's own matchers for jasmine
spies, and these specs use no sinon spies.

Node dependencies are installed with pnpm 10, the version pnpm-lock.yaml is
resolved with. The unused npm and bower rules the target replaces were dead,
none of their variables were ever defined on this branch either.

Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Co-authored-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: oc-tmueller

.github/workflows/main.yml

@@ -57,6 +57,17 @@ jobs:
       php-versions: ${{ needs.get-vars.outputs.php-versions }}
       core-ref-php74: '10.16'
 
+  js-unit:
+    name: JS Unit
+    needs:
+      - get-vars
+    uses: owncloud/reusable-workflows/.github/workflows/js-unit.yml@main
+    with:
+      app-name: ${{ needs.get-vars.outputs.app-name }}
+      php-version: '7.4'
+      # js-unit.yml has no core-ref-php74 input, it clones whatever core-ref says
+      core-ref: '10.16'
+
   build:
     name: Build
     needs:

Makefile

@@ -1,8 +1,9 @@
 SHELL := /bin/bash
 
 COMPOSER_BIN := $(shell command -v composer 2> /dev/null)
-NPM := $(shell command -v npm 2> /dev/null)
-NODE_PREFIX=$(shell pwd)
+# pinned and resolved through npx on purpose: CI has node but not necessarily
+# pnpm. Override with PNPM=<command> to use a local one.
+PNPM ?= npx --yes pnpm@10
 
 app_name=richdocuments
 project_dir=$(CURDIR)/../$(app_name)
@@ -23,6 +24,9 @@ occ=$(CURDIR)/../core/occ
 composer_deps=vendor
 acceptance_test_deps=vendor-bin/behat/vendor
 
+# node
+nodejs_deps=node_modules
+
 appstore:
 	mkdir -p $(sign_dir)
 	rsync -a \
@@ -76,6 +80,7 @@ PHP_CODESNIFFER=vendor-bin/php_codesniffer/vendor/bin/phpcs
 PHAN=php -d zend.enable_gc=0 vendor-bin/phan/vendor/bin/phan
 PHPSTAN=php -d zend.enable_gc=0 vendor-bin/phpstan/vendor/bin/phpstan
 BEHAT_BIN=vendor-bin/behat/vendor/bin/behat
+KARMA=$(CURDIR)/node_modules/.bin/karma
 
 .DEFAULT_GOAL := help
 
@@ -86,14 +91,8 @@ help: ## Show this help message
 #
 # Node dependencies
 #
-$(nodejs_deps): package.json
-	$(NPM) install --prefix $(NODE_PREFIX) && touch $@
-
-$(BOWER): $(nodejs_deps)
-$(JSDOC): $(nodejs_deps)
-
-$(bower_deps): $(BOWER)
-	$(BOWER) install && touch $@
+$(nodejs_deps): package.json pnpm-lock.yaml
+	$(PNPM) install --frozen-lockfile && touch $@
 
 #
 # dist
@@ -132,13 +131,6 @@ clean-deps:
 .PHONY: clean
 clean: clean-deps clean-dist clean-build
 
-##-------------
-## CI
-##-------------
-
-.PHONY: ci
-ci: vendor ## Install dependencies for CI
-
 ##-------------
 ## Tests
 ##-------------
@@ -153,6 +145,16 @@ test-php-unit-dbg: ## Run php unit tests using phpdbg
 test-php-unit-dbg: vendor/bin/phpunit
 	$(PHPUNITDBG) --configuration ./phpunit.xml --testsuite unit
 
+.PHONY: test-js
+test-js: ## Run JavaScript unit tests
+test-js: $(nodejs_deps)
+	$(KARMA) start tests/js/karma.config.cjs --single-run
+
+.PHONY: test-js-debug
+test-js-debug: ## Run JavaScript unit tests and keep watching
+test-js-debug: $(nodejs_deps)
+	$(KARMA) start tests/js/karma.config.cjs
+
 .PHONY: test-php-style
 test-php-style: ## Run php-cs-fixer and check owncloud code-style
 test-php-style: vendor-bin/owncloud-codestyle/vendor vendor-bin/php_codesniffer/vendor
@@ -184,6 +186,11 @@ test-acceptance-webui: ## Run webUI acceptance tests
 test-acceptance-webui: $(acceptance_test_deps)
 	BEHAT_BIN=$(BEHAT_BIN) ../../tests/acceptance/run.sh --remote --type webUI
 
+# Installs dependencies and does any build actions needed for the app to run in CI
+.PHONY: ci
+ci: vendor
+	@echo dependencies and build actions for CI are completed
+
 #
 # Dependency management
 #--------------------------------------

package.json

@@ -16,7 +16,15 @@
     "axios": "^1.16.0",
     "easygettext": "https://github.com/owncloud/easygettext/archive/refs/tags/v2.18.2-oc.tar.gz",
     "eslint": "9.39.5",
+    "jasmine-core": "^7.0.2",
+    "jasmine-sinon": "^0.4.0",
+    "karma": "^6.4.4",
+    "karma-chrome-launcher": "^3.2.0",
+    "karma-firefox-launcher": "^2.1.3",
+    "karma-jasmine": "^5.1.0",
+    "karma-jasmine-sinon": "^1.0.4",
     "prettier": "3.9.6",
+    "sinon": "^19.0.5",
     "typescript": "6.0.3",
     "vite": "^6.4.3",
     "vue": "3.5.42"