fix(web-app-files): [OCISDEV-451] external share ID fallback

Fallback to original ID if decoding the external share ID fails.

Author: LukasHirt

changelog/unreleased/bugfix-external-share-id-fallback.md

@@ -0,0 +1,5 @@
+Bugfix: External share ID fallback
+
+We now fallback to the original ID if decoding the external share ID fails.
+
+https://github.com/owncloud/web/pull/13253

packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue

@@ -287,7 +287,14 @@ const shareOwnerDisplayName = computed(() => share.sharedBy.displayName)
 
 const externalShareDomainName = computed(() => {
   if (unref(isExternalShare)) {
-    const decodedId = atob(share.sharedWith.id)
+    let decodedId = ''
+
+    try {
+      decodedId = atob(share.sharedWith.id)
+    } catch (_) {
+      decodedId = share.sharedWith.id
+    }
+
     const [, serverUrl] = decodedId.split('@')
     const domain = new URL(serverUrl).hostname
 

packages/web-app-files/tests/unit/components/SideBar/Shares/Collaborators/ListItem.spec.ts

@@ -206,6 +206,17 @@ describe('Collaborator ListItem component', () => {
 
       expect(el.text()).toEqual('www.lorem.com')
     })
+
+    it('should fallback to original ID if decoding fails', () => {
+      const share = getShareMock({
+        shareType: ShareTypes.remote.value,
+        sharedWith: { id: 'einstein@https://www.lorem.com', displayName: 'einstein' }
+      })
+      const { wrapper } = createWrapper({ share })
+      const el = wrapper.find('[data-testid="external-share-domain"]')
+
+      expect(el.text()).toEqual('www.lorem.com')
+    })
   })
 })