style: run linter

Jannik Stehle · Jannik Stehle · commit 6ee6ee57504a · 2024-09-04T14:59:18.000+02:00
diff --git a/packages/design-system/src/components/OcApplicationIcon/OcApplicationIcon.vue b/packages/design-system/src/components/OcApplicationIcon/OcApplicationIcon.vue
@@ -58,7 +58,7 @@ export default defineComponent({
       return !!props.colorSecondary
     })
     const generatedHashedPrimaryColor = computed((): string => {
-      let hashedColor = generateHashedColorForString(props.icon)
+      const hashedColor = generateHashedColorForString(props.icon)
       return rgbToHex(setDesiredContrastRatio(hexToRgb(hashedColor), hexToRgb('#ffffff'), 4))
     })
     const iconStyle = computed(() => {
diff --git a/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue b/packages/design-system/src/components/OcCheckbox/OcCheckbox.vue
@@ -50,7 +50,7 @@ export default defineComponent({
      *
      * Can be any type, but most common is boolean for singular checkbox use, or array when used in a group of checkboxes.
      **/
-    // eslint-disable-next-line vue/require-prop-types
+
     modelValue: {
       type: [Boolean, Array] as PropType<boolean | unknown[]>,
       required: false,
diff --git a/packages/design-system/src/components/OcGrid/OcGrid.vue b/packages/design-system/src/components/OcGrid/OcGrid.vue
@@ -35,7 +35,7 @@ export default defineComponent({
   },
   computed: {
     classes() {
-      let c = []
+      const c = []
 
       c.push('oc-grid-' + this.gutter)
 
diff --git a/packages/design-system/src/components/OcRadio/OcRadio.vue b/packages/design-system/src/components/OcRadio/OcRadio.vue
@@ -50,7 +50,7 @@ export default defineComponent({
      *
      * Can be any type.
      **/
-    // eslint-disable-next-line vue/require-prop-types
+
     modelValue: {
       type: [String, Number, Boolean, Object],
       required: false,
diff --git a/packages/design-system/src/components/OcTextInput/OcTextInput.vue b/packages/design-system/src/components/OcTextInput/OcTextInput.vue
@@ -288,7 +288,7 @@ export default defineComponent({
         additionalAttrs['has-error'] = !!this.errorMessage
       }
       // Exclude listeners for events which are handled via methods in this component
-      // eslint-disable-next-line no-unused-vars
+
       const { change, input, focus, class: classes, ...attrs } = this.$attrs
 
       return { ...attrs, ...additionalAttrs }
diff --git a/packages/design-system/src/index.spec.ts b/packages/design-system/src/index.spec.ts
@@ -50,7 +50,7 @@ describe('Depending on what gets passed into the theming options', () => {
     )
     expect(document.documentElement.style.getPropertyValue('--oc-space-small')).toMatch('20px')
   })
-  // eslint-disable-next-line
+
   // it('Defaults to ODS colors where none are passed in theming options', () => {
   //   expect(document.documentElement.style.getPropertyValue('--oc-color')).toMatch("green")
   //   expect(document.documentElement.style.getPropertyValue('--oc-brand-primary-hover')).toMatch('#223959')
diff --git a/packages/design-system/src/utils/webFontLoader.ts b/packages/design-system/src/utils/webFontLoader.ts
@@ -2,7 +2,7 @@
  * Web Font Loader takes care of ownCloud Design System’s font loading.
  * For full documentation, see: https://github.com/typekit/webfontloader
  */
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import WebFont from 'webfontloader'
 
diff --git a/packages/web-app-epub-reader/src/App.vue b/packages/web-app-epub-reader/src/App.vue
@@ -140,8 +140,8 @@ export default defineComponent({
     const localStorageData = useLocalStorage<{ fontSizePercentage?: number }>(`oc_epubReader`, {})
     const currentFontSizePercentage = ref(unref(localStorageData).fontSizePercentage || 100)
     const themeStore = useThemeStore()
-    let book = ref<Book>()
-    let rendition = ref<Rendition>()
+    const book = ref<Book>()
+    const rendition = ref<Rendition>()
 
     const navigateLeft = () => {
       unref(rendition).prev()
diff --git a/packages/web-app-files/src/helpers/textUtils.ts b/packages/web-app-files/src/helpers/textUtils.ts
@@ -39,7 +39,7 @@ function naturalSortCompare(a: string, b: string) {
       aNum = Number(aa[x])
       bNum = Number(bb[x])
       // note: == is correct here
-      // eslint-disable-next-line eqeqeq
+
       if (aNum == aa[x] && bNum == bb[x]) {
         return aNum - bNum
       } else {
diff --git a/packages/web-app-files/src/views/spaces/DriveResolver.vue b/packages/web-app-files/src/views/spaces/DriveResolver.vue
@@ -155,7 +155,7 @@ export default defineComponent({
          * find an easy way to do that.
          **/
         if (space.fileId === space.id) {
-          let publicSpace = (await getSpaceResource()) as PublicSpaceResource
+          const publicSpace = (await getSpaceResource()) as PublicSpaceResource
 
           // FIXME: check for type once https://github.com/owncloud/ocis/issues/8740 is resolved
           if (publicSpace.publicLinkPermission === SharePermissionBit.Create) {
diff --git a/packages/web-app-importer/src/extensions.ts b/packages/web-app-importer/src/extensions.ts
@@ -13,7 +13,7 @@ import type { UppyService } from '@ownclouders/web-pkg'
 import '@uppy/dashboard/dist/style.min.css'
 import { Extension } from '@ownclouders/web-pkg'
 import { ApplicationSetupOptions } from '@ownclouders/web-pkg'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import { WebdavPublicLink } from '@uppy/webdav'
 
diff --git a/packages/web-app-ocm/src/views/App.vue b/packages/web-app-ocm/src/views/App.vue
@@ -65,7 +65,7 @@ export default defineComponent({
     }
 
     const highlightNewConnections = async () => {
-      let oldConnections = [...unref(connections)]
+      const oldConnections = [...unref(connections)]
       await findAcceptedUsers()
       if (oldConnections.length < unref(connections).length) {
         highlightedConnections.value = unref(connections).filter(
diff --git a/packages/web-app-ocm/src/views/IncomingInvitations.vue b/packages/web-app-ocm/src/views/IncomingInvitations.vue
@@ -167,7 +167,7 @@ export default defineComponent({
       }
       const providerDomainQuery = to.query.providerDomain
       if (providerDomainQuery) {
-        let matchedProvider = unref(providers)?.find(
+        const matchedProvider = unref(providers)?.find(
           (p) => p.domain === queryItemAsString(providerDomainQuery)
         )
         if (matchedProvider) {
diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue
@@ -367,7 +367,7 @@ export default defineComponent({
     },
     preloadImages() {
       const preloadFile = (preloadFileIndex: number) => {
-        let cycleIndex =
+        const cycleIndex =
           (((this.activeIndex + preloadFileIndex) % this.filteredFiles.length) +
             this.filteredFiles.length) %
           this.filteredFiles.length
diff --git a/packages/web-app-search/src/index.ts b/packages/web-app-search/src/index.ts
@@ -1,6 +1,6 @@
 import App from './App.vue'
 import List from './views/List.vue'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import translations from '../l10n/translations.json'
 import { ApplicationInformation, defineWebApplication } from '@ownclouders/web-pkg'
diff --git a/packages/web-client/src/ocs/capabilities.ts b/packages/web-client/src/ocs/capabilities.ts
@@ -1,7 +1,6 @@
 import { AxiosInstance } from 'axios'
 import get from 'lodash-es/get'
 
-/* eslint-disable camelcase */
 export interface AppProviderCapability {
   apps_url?: string
   enabled?: boolean
@@ -45,7 +44,7 @@ export interface ArchiverCapability {
   enabled?: boolean
   version?: string // version is just a major version, e.g. `v2`
   formats?: string[]
-  // eslint-disable-next-line camelcase
+
   archiver_url?: string
   max_num_files?: string
   max_size?: string
@@ -185,7 +184,6 @@ export interface Capabilities {
     string?: string
   }
 }
-/* eslint-enable camelcase */
 
 export const GetCapabilitiesFactory = (baseURI: string, axios: AxiosInstance) => {
   const url = new URL(baseURI)
diff --git a/packages/web-pkg/src/components/CreateLinkModal.vue b/packages/web-pkg/src/components/CreateLinkModal.vue
@@ -246,7 +246,7 @@ export default defineComponent({
         )
       }
 
-      let userFacingErrors: Error[] = []
+      const userFacingErrors: Error[] = []
       const failed = result.filter(({ status }) => status === 'rejected')
       if (failed.length) {
         ;(failed as PromiseRejectedResult[])
diff --git a/packages/web-pkg/src/components/CreateShortcutModal.vue b/packages/web-pkg/src/components/CreateShortcutModal.vue
@@ -179,7 +179,7 @@ export default defineComponent({
     let markInstance: Mark = null
 
     const getInputUrlWithProtocol = (input: string) => {
-      let url = input.trim()
+      const url = input.trim()
       if (isMaybeUrl(url)) {
         return url
       }
diff --git a/packages/web-pkg/src/composables/sort/useSort.ts b/packages/web-pkg/src/composables/sort/useSort.ts
@@ -15,7 +15,7 @@ export enum SortDir {
 export interface SortField {
   name: string
   prop?: string
-  // eslint-disable-next-line @typescript-eslint/ban-types
+  // eslint-disable-next-line
   sortable?: MaybeRef<boolean | Function | string>
   sortDir?: MaybeRef<SortDir>
   label?: string
diff --git a/packages/web-pkg/src/helpers/resource/conflictHandling/conflictDialog.ts b/packages/web-pkg/src/helpers/resource/conflictHandling/conflictDialog.ts
@@ -12,7 +12,6 @@ export interface FileConflict {
 }
 
 export class ConflictDialog {
-  /* eslint-disable no-useless-constructor */
   constructor(
     protected $gettext: Language['$gettext'],
     protected $ngettext: Language['$ngettext']
diff --git a/packages/web-pkg/src/services/archiver.ts b/packages/web-pkg/src/services/archiver.ts
@@ -1,8 +1,8 @@
 // Workaround https://github.com/npm/node-semver/issues/381
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import major from 'semver/functions/major'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import rcompare from 'semver/functions/rcompare'
 
diff --git a/packages/web-pkg/src/services/passwordPolicy/passwordPolicy.ts b/packages/web-pkg/src/services/passwordPolicy/passwordPolicy.ts
@@ -10,7 +10,7 @@ import {
 import { PasswordPolicyCapability } from '@ownclouders/web-client/ocs'
 import { GeneratePassword } from 'js-generate-password'
 import { CapabilityStore } from '../../composables'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import { PasswordPolicy } from 'password-sheriff'
 
diff --git a/packages/web-pkg/src/services/preview/previewService.ts b/packages/web-pkg/src/services/preview/previewService.ts
@@ -5,7 +5,7 @@ import { encodePath } from '../../utils'
 import { isPublicSpaceResource } from '@ownclouders/web-client'
 import { BuildQueryStringOptions, LoadPreviewOptions } from '.'
 import { AuthStore, CapabilityStore, ConfigStore, UserStore } from '../../composables'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import { stringify } from 'qs'
 
diff --git a/packages/web-pkg/src/services/uppy/uppyService.ts b/packages/web-pkg/src/services/uppy/uppyService.ts
@@ -7,10 +7,10 @@ import { eventBus } from '../eventBus'
 import DropTarget from '@uppy/drop-target'
 import { Resource, urlJoin } from '@ownclouders/web-client'
 import { UppyResource } from './types'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import getFileType from '@uppy/utils/lib/getFileType'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+
 // @ts-ignore
 import generateFileID from '@uppy/utils/lib/generateFileID'
 
diff --git a/packages/web-pkg/tests/unit/utils/urlJoin.spec.ts b/packages/web-pkg/tests/unit/utils/urlJoin.spec.ts
@@ -15,7 +15,6 @@ describe('proper-url-join', () => {
     [['//', '/fol//der//', '//file'], '/fol/der/file'],
     [['?&@'], '/?&@']
   ])('joins %s as %s', (args: unknown, expected: string) => {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     expect(urlJoin(...args)).toBe(expected)
   })
diff --git a/packages/web-runtime/src/components/Account/AccountTable.vue b/packages/web-runtime/src/components/Account/AccountTable.vue
@@ -27,7 +27,7 @@ export default defineComponent({
       required: true
     },
     fields: {
-      type: Array<String>,
+      type: Array<string>,
       required: true
     }
   }
diff --git a/packages/web-runtime/src/components/UploadInfo.vue b/packages/web-runtime/src/components/UploadInfo.vue
@@ -669,7 +669,7 @@ export default defineComponent({
 
       //TODO: Remove extraction code as soon as https://github.com/tus/tus-js-client/issues/448 is solved
       const formatErrorMessageToObject = (errorMessage: string) => {
-        let responseCode = errorMessage.match(/response code: (\d+)/)?.[1]
+        const responseCode = errorMessage.match(/response code: (\d+)/)?.[1]
         const errorBody = JSON.parse(
           errorMessage.match(/response text: ([\s\S]+?), request id/)?.[1] || '{}'
         )
diff --git a/packages/web-runtime/src/container/application/index.ts b/packages/web-runtime/src/container/application/index.ts
@@ -6,10 +6,10 @@ import { applicationStore } from '../store'
 import { isObject } from 'lodash-es'
 
 // import modules to provide them to applications
-import * as vue from 'vue' // eslint-disable-line
-import * as luxon from 'luxon' // eslint-disable-line
-import * as vueGettext from 'vue3-gettext' // eslint-disable-line
-import * as pinia from 'pinia' // eslint-disable-line
+import * as vue from 'vue'
+import * as luxon from 'luxon'
+import * as vueGettext from 'vue3-gettext'
+import * as pinia from 'pinia'
 import * as webPkg from '@ownclouders/web-pkg'
 import * as webClient from '@ownclouders/web-client'
 import * as webClientGraph from '@ownclouders/web-client/graph'
diff --git a/packages/web-runtime/src/router/index.ts b/packages/web-runtime/src/router/index.ts
@@ -14,7 +14,6 @@ import {
   RouteLocationNormalizedLoaded
 } from 'vue-router'
 
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import qs from 'qs'
 
diff --git a/packages/web-runtime/src/services/clientRegistration.ts b/packages/web-runtime/src/services/clientRegistration.ts
@@ -32,9 +32,8 @@ async function post(url: string, data: unknown) {
 export async function registerClient(openIdConfig: OpenIdConnectConfig) {
   const clientData = JSON.parse(sessionStorage.getItem('dynamicClientData'))
   if (clientData !== null) {
-    // eslint-disable-next-line camelcase
     const client_secret_expires_at = clientData.client_secret_expires_at || 0
-    // eslint-disable-next-line camelcase
+
     if (client_secret_expires_at === 0 || Date.now() < client_secret_expires_at * 1000) {
       return JSON.parse(clientData)
     }
diff --git a/tests/e2e/support/objects/app-files/resource/index.ts b/tests/e2e/support/objects/app-files/resource/index.ts
@@ -105,7 +105,6 @@ export class Resource {
     await this.#page.goto(startUrl)
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-function
   async open(): Promise<void> {}
 
   async restoreVersion(args: Omit<po.resourceVersionArgs, 'page'>): Promise<void> {

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export default defineComponent({`
`50`	`50`	`*`
`51`	`51`	`* Can be any type, but most common is boolean for singular checkbox use, or array when used in a group of checkboxes.`
`52`	`52`	`**/`
`53`		`- // eslint-disable-next-line vue/require-prop-types`
	`53`	`+`
`54`	`54`	`modelValue: {`
`55`	`55`	`type: [Boolean, Array] as PropType<boolean \| unknown[]>,`
`56`	`56`	`required: false,`
Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ export default defineComponent({`
`288`	`288`	`additionalAttrs['has-error'] = !!this.errorMessage`
`289`	`289`	`}`
`290`	`290`	`// Exclude listeners for events which are handled via methods in this component`
`291`		`- // eslint-disable-next-line no-unused-vars`
	`291`	`+`
`292`	`292`	`const { change, input, focus, class: classes, ...attrs } = this.$attrs`
`293`	`293`
`294`	`294`	`return { ...attrs, ...additionalAttrs }`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ describe('Depending on what gets passed into the theming options', () => {`
`50`	`50`	`)`
`51`	`51`	`expect(document.documentElement.style.getPropertyValue('--oc-space-small')).toMatch('20px')`
`52`	`52`	`})`
`53`		`- // eslint-disable-next-line`
	`53`	`+`
`54`	`54`	`// it('Defaults to ODS colors where none are passed in theming options', () => {`
`55`	`55`	`// expect(document.documentElement.style.getPropertyValue('--oc-color')).toMatch("green")`
`56`	`56`	`// expect(document.documentElement.style.getPropertyValue('--oc-brand-primary-hover')).toMatch('#223959')`