Skip to content

Commit 7675f7e

Browse files
Add draft for fixing (aria-)label bug on OcSelect
1 parent a7d3f43 commit 7675f7e

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

packages/design-system/src/components/OcPageSize/OcPageSize.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
data-testid="oc-page-size-label"
77
v-text="label"
88
/>
9+
<!-- Streamline label above into oc-select? -->
910
<oc-select
1011
:input-id="selectId"
1112
class="oc-page-size-select"

packages/design-system/src/components/OcSelect/OcSelect.vue

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
<template>
22
<div>
3-
<label v-if="label" :for="id" class="oc-label" v-text="label" />
3+
<label
4+
v-if="label"
5+
:for="id"
6+
:class="{ 'oc-invisible-sr': isLabelHidden }"
7+
class="oc-label"
8+
v-text="label"
9+
/>
410
<oc-contextual-helper
511
v-if="contextualHelper?.isEnabled"
612
v-bind="contextualHelper?.data"
@@ -279,6 +285,10 @@ export default defineComponent({
279285
readOnly: {
280286
type: Boolean,
281287
default: false
288+
},
289+
isLabelHidden: {
290+
type: Boolean,
291+
default: false
282292
}
283293
},
284294
emits: ['search:input', 'update:modelValue'],
@@ -303,7 +313,9 @@ export default defineComponent({
303313
}
304314
305315
onMounted(() => {
306-
setComboBoxAriaLabel()
316+
if (!props.label) {
317+
setComboBoxAriaLabel()
318+
}
307319
})
308320
309321
const dropdownEnabled = ref(false)

packages/web-app-files/src/components/SideBar/Details/TagsSelect.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
<oc-select
33
ref="tagSelect"
44
v-model="selectedTags"
5+
:label="$gettext('Add or edit tags')"
6+
:is-label-hidden="true"
57
class="tags-select"
68
:multiple="true"
79
:disabled="readonly"

0 commit comments

Comments
 (0)