Merge pull request #12105 from owncloud/feat/editorless-extensions

feat: handle editor-less extensions

Author: LukasHirt

changelog/unreleased/enhancement-handle-extensions-without-editor.md

@@ -0,0 +1,5 @@
+Enhancement: Handle extensions without editor
+
+We've added a new property to extensions that asserts whether is has an editor or not. This property is computed by checking whether the extension exposes any routes.
+
+https://github.com/owncloud/web/pull/12105

packages/web-pkg/src/apps/types.ts

@@ -92,6 +92,8 @@ export interface ApplicationInformation {
   translations?: Translations
   /** @deprecated */
   applicationMenu?: ApplicationMenuItem
+  /** Asserts whether the app has any route which works as an editor */
+  hasEditor?: boolean
 }
 
 /**
@@ -105,7 +107,7 @@ export interface ApplicationTranslations {
 
 /** ClassicApplicationScript reflects classic application script structure */
 export interface ClassicApplicationScript {
-  appInfo?: ApplicationInformation
+  appInfo?: Omit<ApplicationInformation, 'hasEditor'>
   routes?: ((args: ComponentCustomProperties) => RouteRecordRaw[]) | RouteRecordRaw[]
   navItems?: ((args: ComponentCustomProperties) => AppNavigationItem[]) | AppNavigationItem[]
   translations?: ApplicationTranslations

packages/web-pkg/src/composables/actions/files/useFileActions.ts

@@ -112,6 +112,7 @@ export const useFileActions = () => {
     }
 
     return appsStore.fileExtensions
+      .filter((fileExtension) => appsStore.apps[fileExtension.app]?.hasEditor)
       .map((fileExtension): FileAction => {
         const appInfo = appsStore.apps[fileExtension.app]
 

packages/web-pkg/tests/unit/composables/actions/files/useFileActions.spec.ts

@@ -90,13 +90,22 @@ function getWrapper({ setup }: { setup: (instance: ReturnType<typeof useFileActi
                     {
                       extension: 'txt'
                     }
-                  ]
+                  ],
+                  hasEditor: true
                 },
                 external: {
                   defaultExtension: '',
                   icon: 'check_box_outline_blank',
                   name: 'External',
-                  id: 'external'
+                  id: 'external',
+                  hasEditor: true
+                },
+                'editor-less': {
+                  defaultExtension: '',
+                  icon: 'check_box_outline_blank',
+                  name: 'Editor Less',
+                  id: 'editor-less',
+                  hasEditor: false
                 }
               },
               fileExtensions: [

packages/web-runtime/src/container/application/classic.ts

@@ -110,7 +110,10 @@ export const convertClassicApplication = ({
   })
 
   const appsStore = useAppsStore()
-  appsStore.registerApp(applicationScript.appInfo, applicationScript.translations)
+  appsStore.registerApp(
+    { ...applicationScript.appInfo, hasEditor: applicationScript.routes?.length > 0 },
+    applicationScript.translations
+  )
 
   if (applicationScript.extensions) {
     extensionRegistry.registerExtensions(applicationScript.extensions)