eslint-plugin-sonar/sonarjs

[Goldziher]

SonarQube has a very useful EsLint plugin (eslint-plugin-sonarjs) - I was always a fan of their "cognitive complexity" over other implementations of complexity measurement for example, and their rules are very useful as a style guide as well. Recently a new plugin was released that extracts all the rules from Sonar (eslint-plugin-sonar), which isn't official.

It would be great to have at least some of the rules from these plugins implemented in oxclint.

For reference:

eslint-plugin-sonarjs
eslint-plugin-sonar

[Goldziher]

@rzvxa @DonIsaac whats the rfc process?

[DonIsaac]

I was thinking about this too, but we may run into problems considering it's LGPL licensed.

[Goldziher]

The LGPL license is for their code, it can't cover the functionality itself.

[DonIsaac]

We'd then need to guarantee that every contribution was created without reading their code... which isn't really viable if we're taking public contributions.

We could potentially port over some rules, but only if maintainers wrote them and were very careful about how they did so. I'm not sure this is worth it in most cases, but it is very tempting for some of their rules.

[Boshen]

Biome implemented one too https://biomejs.dev/linter/rules/no-excessive-cognitive-complexity/

[Goldziher]

Or it's possible to ask for permission?

[Hideman85]

Hi, jumping in this discussion, I also beleive there is quite some great rules that would be very nice to be seen ported to oxlint. I'm already enjoying a lot the port of unicorn rules and I'm thinking sonar rules is a great addition.

Furthermore, in corporate environment, sonar is well known and used for the vulnerabilities and quality scanning over the codebase. Having oxlint blazing fast checking those rules and auto-fixing some of them is a great value.

Looking forward to see if this is something that could be integrated or not.

[alfaproject]

We also require sonarjs rules to work before we can switch to Oxlint and we won't keep both ESLint and Oxlint in the same codebase, so until Oxlint supports sonarjs I guess we are out of luck.

The problem with sonarjs rules is that some of them are type-aware and I don't think that's supported by Oxlint JS plugins implementation atm

[camc314]

You can use it as a custom plugin.

Please track #19596 for type access for custom plugins

[alfaproject]

Oh nice, that's good news, thanks!