Add tests demonstrating occurrences on punned expressions

Author: liam923

tests/test-dirs/occurrences/project-wide/punning.t/definitions.ml

@@ -0,0 +1,4 @@
+let a = Some 1
+
+type t = { value : string }
+let value = "hello"

tests/test-dirs/occurrences/project-wide/punning.t/run.t

@@ -0,0 +1,48 @@
+Test project-wide occurrences in the presence of punning (both let and record punning)
+
+Compile project, create index file, and configure Merlin to use index file
+  $ $OCAMLC -bin-annot -bin-annot-occurrences -c definitions.ml usages.ml
+  $ ocaml-index aggregate definitions.cmt usages.cmt
+  $ cat > .merlin << EOF
+  > INDEX project.ocaml-index
+  > EOF
+
+Convenience function for querying occurrences
+  $ occurrences () {
+  >   file="$1"
+  >   location="$2"
+  >   $MERLIN single occurrences -scope project -identifier-at "$location" -filename "$file" < "$file" | \
+  >     jq -r '.value[] | "\(.file) \(.start.line):\(.start.col)-\(.end.col)"'
+  > }
+
+Get occurrences of an identifier that is used as the expression part of a punned let
+expression
+FIXME: this should also include the occurrence on line 6 of usages.ml
+  $ occurrences definitions.ml 1:4
+  $TESTCASE_ROOT/definitions.ml 1:4-5
+
+Get occurrences, with the cursor pointing at the identifier in a punned let.
+Merlin returns the occurrences of the new variable bound in that let, rather than the
+expression being assigned to the variable.
+  $ occurrences usages.ml 6:7
+  $TESTCASE_ROOT/usages.ml 6:7-8
+  $TESTCASE_ROOT/usages.ml 7:7-8
+
+Get occurrences of a record field, where there is an instance of punning that field while
+creating a record
+  $ occurrences definitions.ml 3:13
+  $TESTCASE_ROOT/definitions.ml 3:11-16
+  $TESTCASE_ROOT/usages.ml 10:10-15
+
+Get occurrences of a variable that is used as the value being placed into a record in a
+punned record field expression
+  $ occurrences definitions.ml 4:6
+  $TESTCASE_ROOT/definitions.ml 4:4-9
+  $TESTCASE_ROOT/usages.ml 10:10-15
+
+Get occurrences, with the cursor pointing at a punned record field expression.
+Merlin finds occurrences of the value being placed into the record rather than the record
+field
+  $ occurrences usages.ml 10:12
+  $TESTCASE_ROOT/definitions.ml 4:4-9
+  $TESTCASE_ROOT/usages.ml 10:10-15

tests/test-dirs/occurrences/project-wide/punning.t/usages.ml

@@ -0,0 +1,10 @@
+include Definitions
+
+(* Let punning *)
+let _ =
+  let (let*) = Option.bind in
+  let* a in
+  Some a
+
+(* Record field punning *)
+let _ = { value }

tests/test-dirs/occurrences/punning.t/run.t

@@ -0,0 +1,45 @@
+Test occurrences in the presence of punning (both let and record punning)
+
+Convenience function for querying occurrences
+  $ occurrences () {
+  >   location="$1"
+  >   $MERLIN single occurrences -identifier-at "$location" -filename test.ml < test.ml | \
+  >     jq -r '.value[] | "\(.start.line):\(.start.col)-\(.end.col)"'
+  > }
+
+Get occurrences of an identifier that is used as the expression part of a punned let
+expression
+FIXME: this should also include the occurrence on line 5
+  $ occurrences 4:6
+  4:6-7
+
+Get occurrences, with the cursor pointing at the identifier in a punned let.
+Merlin returns the occurrences of the new variable bound in that let, rather than the
+expression being assigned to the variable.
+  $ occurrences 5:7
+  5:7-8
+  6:7-8
+
+Get occurrences of an identifier that was defined in a punned let expression
+  $ occurrences 5:7
+  5:7-8
+  6:7-8
+
+Get occurrences of a record field, where there is an instance of punning that field while
+creating a record
+  $ occurrences 9:13
+  9:11-16
+  11:10-15
+
+Get occurrences of a variable that is used as the value being placed into a record in a
+punned record field expression
+  $ occurrences 10:4
+  10:4-9
+  11:10-15
+
+Get occurrences, with the cursor pointing at a punned record field expression.
+Merlin finds occurrences of the value being placed into the record rather than the record
+field
+  $ occurrences 10:4
+  10:4-9
+  11:10-15

tests/test-dirs/occurrences/punning.t/test.ml

@@ -0,0 +1,11 @@
+(* Let punning *)
+let _ =
+  let (let*) = Option.bind in
+  let a = Some 1 in
+  let* a in
+  Some a
+
+(* Record field punning *)
+type t = { value : string }
+let value = "hello"
+let _ = { value }