Promote failing tests

liam923 · liam923 · commit 2678281eb897 · 2025-01-16T14:12:33.000-05:00
diff --git a/tests/test-dirs/function-recovery.t b/tests/test-dirs/function-recovery.t
@@ -20,7 +20,7 @@
                 <def>
                   pattern (test.ml[2,79+6]..test.ml[2,79+13])
                     Tpat_var \"problem/275\"
-                    value_mode meet(local,once,nonportable)(modevar#0[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
+                    value_mode meet(local,once,nonportable,yielding)(modevar#0[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
                   expression (test.ml[2,79+16]..test.ml[2,79+24])
                     Texp_variant \"Problem\"
                     None
@@ -35,7 +35,7 @@
                     None
                   expression (test.ml[3,104+11]..test.ml[3,104+28])
                     Texp_function
-                    alloc_mode id(modevar#d[global,many,portable .. local,once,nonportable]);id(modevar#e[aliased,contended .. unique,uncontended])
+                    alloc_mode id(modevar#d[global,many,portable,unyielding .. local,once,nonportable,yielding]);id(modevar#e[aliased,contended .. unique,uncontended])
                     []
                     Tfunction_body
                       expression (test.ml[3,104+11]..test.ml[3,104+28])
@@ -69,12 +69,12 @@
         <def>
           pattern (type.ml[1,0+4]..type.ml[1,0+5])
             Tpat_var \"f/275\"
-            value_mode meet(local,once,nonportable)(modevar#0[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
+            value_mode meet(local,once,nonportable,yielding)(modevar#0[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
           expression (type.ml[1,0+8]..type.ml[1,0+61])
             extra
               Texp_newtype  t
             Texp_function
-            alloc_mode map_comonadic(regional_to_global)(modevar#2[global,many,portable .. global,many,nonportable]);id(modevar#3[aliased,contended .. unique,uncontended])
+            alloc_mode map_comonadic(regional_to_global)(modevar#2[global,many,portable,unyielding .. global,many,nonportable,unyielding]);id(modevar#3[aliased,contended .. unique,uncontended])
             [
               Nolabel
               Param_pat
@@ -89,7 +89,7 @@
                           []
                       ]
                   Tpat_var \"foo/278\"
-                  value_mode map_comonadic(local_to_regional)(modevar#4[global,many,portable .. local,once,nonportable]);join(aliased,contended)(modevar#5[aliased,contended .. unique,uncontended])
+                  value_mode map_comonadic(local_to_regional)(modevar#4[global,many,portable,unyielding .. local,once,nonportable,yielding]);join(aliased,contended)(modevar#5[aliased,contended .. unique,uncontended])
             ]
             Tfunction_body
               expression (type.ml[1,0+39]..type.ml[1,0+61])
@@ -193,7 +193,7 @@
                     "attrs": [],
                     "kind": "pattern (test.ml[1,0+4]..test.ml[1,0+5])
     Tpat_var \"f/275\"
-    value_mode meet(local,once,nonportable)(modevar#0[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
+    value_mode meet(local,once,nonportable,yielding)(modevar#0[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
   ",
                     "children": []
                   },
@@ -225,7 +225,7 @@
                         "attrs": [],
                         "kind": "pattern (test.ml[1,0+6]..test.ml[1,0+9])
     Tpat_var \"x/277\"
-    value_mode map_comonadic(local_to_regional)(modevar#4[global,many,portable .. local,once,nonportable]);join(aliased,contended)(modevar#5[aliased,contended .. unique,uncontended])
+    value_mode map_comonadic(local_to_regional)(modevar#4[global,many,portable,unyielding .. local,once,nonportable,yielding]);join(aliased,contended)(modevar#5[aliased,contended .. unique,uncontended])
   ",
                         "children": []
                       },
@@ -456,7 +456,7 @@
     [
       pattern (test.ml[4,57+9]..test.ml[4,57+12])
         Tpat_var \"_aa/278\"
-        value_mode global,many,portable;unique,uncontended
+        value_mode global,many,portable,unyielding;unique,uncontended
     ]
     None
   ",
@@ -475,7 +475,7 @@
                                         "attrs": [],
                                         "kind": "pattern (test.ml[4,57+9]..test.ml[4,57+12])
     Tpat_var \"_aa/278\"
-    value_mode global,many,portable;unique,uncontended
+    value_mode global,many,portable,unyielding;unique,uncontended
   ",
                                         "children": []
                                       }
diff --git a/tests/test-dirs/type-enclosing/underscore-ids.t b/tests/test-dirs/type-enclosing/underscore-ids.t
@@ -372,7 +372,7 @@ We try several places in the identifier to check the result stability
         <def>
           pattern (under.ml[1,0+4]..under.ml[1,0+6])
             Tpat_var \"aa/275\"
-            value_mode meet(local,once,nonportable)(modevar#0[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
+            value_mode meet(local,once,nonportable,yielding)(modevar#0[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
           expression (under.ml[1,0+9]..under.ml[1,0+12])
             Texp_constant Const_float 4.2
       ]
@@ -382,16 +382,16 @@ We try several places in the identifier to check the result stability
         <def>
           pattern (under.ml[2,13+4]..under.ml[2,13+5])
             Tpat_var \"f/276\"
-            value_mode meet(local,once,nonportable)(modevar#3[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#4[aliased,uncontended .. unique,uncontended])
+            value_mode meet(local,once,nonportable,yielding)(modevar#3[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#4[aliased,uncontended .. unique,uncontended])
           expression (under.ml[2,13+6]..under.ml[5,70+17]) ghost
             Texp_function
-            alloc_mode map_comonadic(regional_to_global)(modevar#5[global,many,portable .. global,many,nonportable]);id(modevar#6[aliased,contended .. unique,uncontended])
+            alloc_mode map_comonadic(regional_to_global)(modevar#5[global,many,portable,unyielding .. global,many,nonportable,unyielding]);id(modevar#6[aliased,contended .. unique,uncontended])
             [
               Nolabel
               Param_pat
                 pattern (under.ml[2,13+6]..under.ml[2,13+9])
                   Tpat_var \"x/278\"
-                  value_mode map_comonadic(local_to_regional)(modevar#7[global,many,portable .. local,once,nonportable]);join(aliased,contended)(modevar#8[aliased,contended .. unique,uncontended])
+                  value_mode map_comonadic(local_to_regional)(modevar#7[global,many,portable,unyielding .. local,once,nonportable,yielding]);join(aliased,contended)(modevar#8[aliased,contended .. unique,uncontended])
             ]
             Tfunction_body
               expression (under.ml[2,13+18]..under.ml[5,70+17])
diff --git a/tests/test-dirs/typing-recovery.t b/tests/test-dirs/typing-recovery.t
@@ -94,10 +94,10 @@
         <def>
           pattern (test.ml[2,15+4]..test.ml[2,15+5])
             Tpat_var \"f/278\"
-            value_mode meet(local,once,nonportable)(modevar#0[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
+            value_mode meet(local,once,nonportable,yielding)(modevar#0[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
           expression (test.ml[2,15+6]..test.ml[6,69+12]) ghost
             Texp_function
-            alloc_mode map_comonadic(regional_to_global)(modevar#2[global,many,portable .. global,many,nonportable]);id(modevar#3[aliased,contended .. unique,uncontended])
+            alloc_mode map_comonadic(regional_to_global)(modevar#2[global,many,portable,unyielding .. global,many,nonportable,unyielding]);id(modevar#3[aliased,contended .. unique,uncontended])
             [
               Nolabel
               Param_pat
@@ -108,7 +108,7 @@
                       Ttyp_constr \"t/275\"
                       []
                   Tpat_var \"x/280\"
-                  value_mode global,many,portable;unique,uncontended
+                  value_mode global,many,portable,unyielding;unique,uncontended
             ]
             Tfunction_body
               expression (test.ml[3,31+2]..test.ml[6,69+12])
@@ -254,10 +254,10 @@
         <def>
           pattern (test2.ml[2,15+4]..test2.ml[2,15+5])
             Tpat_var \"f/278\"
-            value_mode meet(local,once,nonportable)(modevar#0[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
+            value_mode meet(local,once,nonportable,yielding)(modevar#0[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#1[aliased,uncontended .. unique,uncontended])
           expression (test2.ml[2,15+6]..test2.ml[2,15+24]) ghost
             Texp_function
-            alloc_mode map_comonadic(regional_to_global)(modevar#2[global,many,portable .. global,many,nonportable]);id(modevar#3[aliased,contended .. unique,uncontended])
+            alloc_mode map_comonadic(regional_to_global)(modevar#2[global,many,portable,unyielding .. global,many,nonportable,unyielding]);id(modevar#3[aliased,contended .. unique,uncontended])
             [
               Nolabel
               Param_pat
@@ -284,11 +284,9 @@
                   ]
                 extra
                   Texp_constraint
-                  Some
-                    core_type (test2.ml[2,15+16]..test2.ml[2,15+19])
-                      Ttyp_constr \"int/1!\"
-                      []
-                  alloc_const_option_mode None,None,None,None,None
+                  core_type (test2.ml[2,15+16]..test2.ml[2,15+19])
+                    Ttyp_constr \"int/1!\"
+                    []
                 Texp_ident \"*type-error*/280\"
       ]
   ]
@@ -563,15 +561,15 @@ make sure we also handle that correctly in structures:
                 Ttyp_constr \"int/1!\"
                 []
             Tpat_var \"foo1/275\"
-            value_mode global,many,portable;unique,uncontended
+            value_mode global,many,portable,unyielding;unique,uncontended
           expression (test_ct.ml[1,0+17]..test_ct.ml[1,0+18])
             extra
+              Texp_mode
+              alloc_const_option_mode None,None,None,None,None,None
               Texp_constraint
-              Some
-                core_type (test_ct.ml[1,0+11]..test_ct.ml[1,0+14])
-                  Ttyp_constr \"int/1!\"
-                  []
-              alloc_const_option_mode None,None,None,None,None
+              core_type (test_ct.ml[1,0+11]..test_ct.ml[1,0+14])
+                Ttyp_constr \"int/1!\"
+                []
             Texp_constant Const_int 3
       ]
     structure_item (test_ct.ml[3,20+0]..test_ct.ml[3,20+28])
@@ -594,26 +592,26 @@ make sure we also handle that correctly in structures:
                     None
                 ]
             Tpat_var \"foo2/276\"
-            value_mode meet(local,once,nonportable)(modevar#3[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#4[aliased,uncontended .. unique,uncontended])
+            value_mode meet(local,once,nonportable,yielding)(modevar#3[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#4[aliased,uncontended .. unique,uncontended])
           expression (test_ct.ml[3,20+24]..test_ct.ml[3,20+28])
             extra
+              Texp_mode
+              alloc_const_option_mode None,None,None,None,None,None
               Texp_constraint
-              Some
-                core_type (test_ct.ml[3,20+11]..test_ct.ml[3,20+21])
-                  Ttyp_tuple
-                  [
-                    Label: None
-                    core_type (test_ct.ml[3,20+11]..test_ct.ml[3,20+14])
-                      Ttyp_constr \"int/1!\"
-                      []
-                    Label: None
-                    core_type (test_ct.ml[3,20+17]..test_ct.ml[3,20+21])
-                      Ttyp_var _
-                      None
-                  ]
-              alloc_const_option_mode None,None,None,None,None
+              core_type (test_ct.ml[3,20+11]..test_ct.ml[3,20+21])
+                Ttyp_tuple
+                [
+                  Label: None
+                  core_type (test_ct.ml[3,20+11]..test_ct.ml[3,20+14])
+                    Ttyp_constr \"int/1!\"
+                    []
+                  Label: None
+                  core_type (test_ct.ml[3,20+17]..test_ct.ml[3,20+21])
+                    Ttyp_var _
+                    None
+                ]
             Texp_tuple
-            alloc_mode meet(local,once,nonportable,map_comonadic(regional_to_global)(modevar#3[global,many,portable .. global,many,nonportable]));unique,uncontended
+            alloc_mode meet(local,once,nonportable,yielding,map_comonadic(regional_to_global)(modevar#3[global,many,portable,unyielding .. global,many,nonportable,unyielding]));unique,uncontended
             [
               Label: None
                 expression (test_ct.ml[3,20+24]..test_ct.ml[3,20+25])
@@ -643,26 +641,26 @@ make sure we also handle that correctly in structures:
                     []
                 ]
             Tpat_var \"foo3/277\"
-            value_mode meet(local,once,nonportable)(modevar#6[global,many,portable .. global,many,nonportable]);join(aliased,contended)(modevar#7[aliased,uncontended .. unique,uncontended])
+            value_mode meet(local,once,nonportable,yielding)(modevar#6[global,many,portable,unyielding .. global,many,nonportable,unyielding]);join(aliased,contended)(modevar#7[aliased,uncontended .. unique,uncontended])
           expression (test_ct.ml[5,50+23]..test_ct.ml[5,50+27])
             extra
+              Texp_mode
+              alloc_const_option_mode None,None,None,None,None,None
               Texp_constraint
-              Some
-                core_type (test_ct.ml[5,50+11]..test_ct.ml[5,50+20])
-                  Ttyp_tuple
-                  [
-                    Label: None
-                    core_type (test_ct.ml[5,50+11]..test_ct.ml[5,50+14])
-                      Ttyp_constr \"int/1!\"
-                      []
-                    Label: None
-                    core_type (test_ct.ml[5,50+17]..test_ct.ml[5,50+20])
-                      Ttyp_constr \"int/1!\"
-                      []
-                  ]
-              alloc_const_option_mode None,None,None,None,None
+              core_type (test_ct.ml[5,50+11]..test_ct.ml[5,50+20])
+                Ttyp_tuple
+                [
+                  Label: None
+                  core_type (test_ct.ml[5,50+11]..test_ct.ml[5,50+14])
+                    Ttyp_constr \"int/1!\"
+                    []
+                  Label: None
+                  core_type (test_ct.ml[5,50+17]..test_ct.ml[5,50+20])
+                    Ttyp_constr \"int/1!\"
+                    []
+                ]
             Texp_tuple
-            alloc_mode meet(local,once,nonportable,map_comonadic(regional_to_global)(modevar#6[global,many,portable .. global,many,nonportable]));unique,uncontended
+            alloc_mode meet(local,once,nonportable,yielding,map_comonadic(regional_to_global)(modevar#6[global,many,portable,unyielding .. global,many,nonportable,unyielding]));unique,uncontended
             [
               Label: None
                 expression (test_ct.ml[5,50+23]..test_ct.ml[5,50+24])
