add commentsg

maxmwang · maxmwang · commit b0197f285761 · 2025-08-15T11:58:01.000-04:00
diff --git a/src/kernel/phase_cache.ml b/src/kernel/phase_cache.ml
@@ -36,11 +36,15 @@ module With_cache (Phase : S) = struct
     }
 
   let get_next_version =
+    (* A mutable counter separate from [cache.version] is necessary because of [Phase.f]
+       erroring. In [apply], when [Phase.f = Error], cache is reset to [None], losing the
+       value of [next_version] if not stored elsewhere. *)
     let next_version = ref 0 in
     fun () : Version.t ->
       let v = Some !next_version in
       incr next_version;
       v
+
   let cache = ref None
 
   let apply ?(cache_disabling = None) ?(force_invalidation = false) input =

Original file line number	Diff line number	Diff line change
`@@ -36,11 +36,15 @@ module With_cache (Phase : S) = struct`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`let get_next_version =`
	`39`	`+ (* A mutable counter separate from [cache.version] is necessary because of [Phase.f]`
	`40`	`+ erroring. In [apply], when [Phase.f = Error], cache is reset to [None], losing the`
	`41`	`+ value of [next_version] if not stored elsewhere. *)`
`39`	`42`	`let next_version = ref 0 in`
`40`	`43`	`fun () : Version.t ->`
`41`	`44`	`let v = Some !next_version in`
`42`	`45`	`incr next_version;`
`43`	`46`	`v`
	`47`	`+`
`44`	`48`	`let cache = ref None`
`45`	`49`
`46`	`50`	`let apply ?(cache_disabling = None) ?(force_invalidation = false) input =`