Skip to content

Commit c1cb3d6

Browse files
authored
Comment out probe error (#181)
1 parent 79864a6 commit c1cb3d6

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/ocaml/typing/typecore.ml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7429,10 +7429,15 @@ and type_expect_
74297429
_ } ,
74307430
_)}]) ->
74317431
check_probe_name name name_loc env;
7432-
add_delayed_check
7432+
(* CR-someday: (Merlin-only) This check is commented out because Merlin is
7433+
spuriously raising it when it shouldn't. This is possibly due to probes
7434+
interacting poorly with the typer cache. Until this problem is fixed,
7435+
commenting out this error seems good enough - incorrectly reporting this error
7436+
is far more costly than failing to report it. *)
7437+
(* add_delayed_check
74337438
(fun () ->
74347439
if not (Env.has_probe name) then
7435-
raise(error(name_loc, env, (Probe_name_undefined name))));
7440+
raise(error(name_loc, env, (Probe_name_undefined name)))); *)
74367441
rue {
74377442
exp_desc = Texp_probe_is_enabled {name};
74387443
exp_loc = loc; exp_extra = [];

0 commit comments

Comments
 (0)