Stop server before and after parameters test #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced a flaky failure of the test
tests/test-dirs/parameters.t/run.t:Here's a possible explanation of the flake: I experienced this flake twice, and both times were immediately after pulling changes. Currently, the test uses the merlin server but never stops the server. The flaky run could've been using a server built from the codebase before pulling, which would cause unexpected behavior.
I am not confident of this explanation because I have been unable to replicate the flake by trying to replicate the circumstances. But either way, it is a good idea to stop the server before and after the test (all other tests that use the merlin server do this). So this PR does so. If the flake keeps occurring, then we will revisit the issue.