Add syntax hovers for oxcaml #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam923
force-pushed
the
add-syntax-hovers-for-oxcaml
branch
from
ac1611c to
3040c55
Compare
goldfirere
approved these changes
Sep 9, 2025
Contributor
goldfirere
left a comment
goldfirere
left a comment
There was a problem hiding this comment.
I have nit-picked, as requested.
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Co-authored-by: Richard Eisenberg <[email protected]>
Contributor
Author
|
I suggest re-reviewing |
goldfirere
reviewed
Sep 11, 2025
Contributor
goldfirere
left a comment
goldfirere
left a comment
There was a problem hiding this comment.
Did not re-check strings.
Co-authored-by: Richard Eisenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the syntax doc command to also provide information about pieces of oxcaml syntax. Ideally review of this PR also consists of reviewing the English descriptions that are contained within
syntax_doc.ml(I encourage nit-picking of them).This PR does not fully implement the functionality of hovering over modes and modalities. For this, the typedtree must first be extended to contain mode and modality location information, which is tracked by internal ticket 4845.