Skip to content

Disable probe error #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liam923 merged 1 commit into from
Aug 26, 2025
Merged

Disable probe error #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/ocaml/typing/typecore.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7079,10 +7079,15 @@ and type_expect_
_ } ,
_)}]) ->
check_probe_name name name_loc env;
add_delayed_check
(* CR-someday: (Merlin-only) This check is commented out because Merlin is
spuriously raising it when it shouldn't. This is possibly due to probes
interacting poorly with the typer cache. Until this problem is fixed,
commenting out this error seems good enough - incorrectly reporting this error
is far more costly than failing to report it. *)
(* add_delayed_check
(fun () ->
if not (Env.has_probe name) then
raise(error(name_loc, env, (Probe_name_undefined name))));
raise(error(name_loc, env, (Probe_name_undefined name)))); *)
rue {
exp_desc = Texp_probe_is_enabled {name};
exp_loc = loc; exp_extra = [];
Expand Down