Merge 5.2.0minus-19 #185
Merged
Merge 5.2.0minus-19 #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler Merge ChecklistThis PR seems to merge changes from Flambda. Please be sure to follow the below steps:
If this PR is not merging changes from Flambda, feel free to ignore this comment |
liam923
commented
Sep 16, 2025
liam923
force-pushed
the
merge-5.2.0minus-19
branch
from
ce0e363 to
97c7dad
Compare
spiessimon
approved these changes
Sep 17, 2025
spiessimon
left a comment
spiessimon
left a comment
There was a problem hiding this comment.
The shape related changes look good to me!
goldfirere
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 4 commits (up through 34a88ad) are the result of running the import script and can be skipped. The 5th commit (602224c) can also be skipped if desired - it contains fairly straightforward conflict resolution, but a second set of eyes wouldn't hurt.
Commits 81ee013 and 944ecfe should also be skipped - those are automatic merges due to a compiler retag.
Of the remaining commits, I'd like additional review from a couple people: