Add merlin.ppx_template_generated
#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
approved these changes
Oct 1, 2025
Contributor
dkalinichenko-js
left a comment
dkalinichenko-js
left a comment
There was a problem hiding this comment.
Looks simple enough.
| ("deprecated", `Bool deprecated) | ||
| ] | ||
| @ | ||
| if ppx_template_generated then [ ("ppx_template_generated", `Bool true) ] |
Contributor
There was a problem hiding this comment.
Is the if here for compatibility with the existing RPC interface?
Contributor
Author
There was a problem hiding this comment.
I don't believe it's required for compatibility, but I did this because it limits the test diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an attribute to mark whether an identifier is generated by ppx_template. This turned out to be very easy - I just copied what is done for the
[@@deprecated]attribute.