Skip to content

Add --lalr flag to menhir invocations #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liam923 merged 1 commit into from
Nov 5, 2025
Merged

Add --lalr flag to menhir invocations #194

liam923 merged 1 commit into from
Nov 5, 2025

Conversation

@liam923
Copy link
Contributor

@liam923 liam923 commented Nov 5, 2025

This should give us a perf improvement on the parser. The compiler also passes this flag: https://github.com/oxcaml/oxcaml/blob/6517665264cd1a8fca1662674bc1d218a3ef6c60/dune#L91

@liam923 liam923 requested a review from ccasin November 5, 2025 14:31
ccasin
ccasin approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit to @let-def for spotting this improvement.

@liam923 liam923 mentioned this pull request Nov 5, 2025
Merged
@liam923 liam923 merged commit d1cb27e into main Nov 5, 2025
1 check passed
@liam923 liam923 deleted the pass-lalr-to-menhir branch November 5, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccasin ccasin ccasin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liam923 @ccasin